Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch #3740

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Conversation

Oktai15
Copy link
Contributor

@Oktai15 Oktai15 commented Feb 23, 2022

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [TTS]

Changelog

  • Fix bugs in E2E TTS, Mixer-TTS and FastPitch

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
@Oktai15 Oktai15 requested a review from blisc February 23, 2022 18:14
self.audio_to_melspec_preprocessor = instantiate(cfg.preprocessor)
self.audio_to_melspec_precessor = instantiate(cfg.preprocessor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to put this in a try block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this typo in several models. Let’s discuss how to resolve it out of this PR. In my opinion, code will be too hard with try block, because we can't check only config field, we would need to support two variants of attribute of class (because torch load weights function looks for concrete attribute of class).

@blisc blisc merged commit d50a632 into r1.7.0 Feb 23, 2022
@blisc blisc deleted the fix_tutorial_bugs branch February 23, 2022 20:57
ericharper pushed a commit that referenced this pull request Feb 28, 2022
* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
titu1994 added a commit that referenced this pull request Mar 1, 2022
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* update requirements and package info

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove unused import

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
fayejf pushed a commit that referenced this pull request Mar 2, 2022
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* update requirements and package info

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* revert

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove unused import

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
ericharper added a commit that referenced this pull request Mar 14, 2022
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* fix dockerfile (#3778)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Prompt-Tuning-Documentation (#3777)

* Update megatron.rst

* Updated example prompt tuning script's doc string

* Update megatron.rst

* Update megatron.rst

Co-authored-by: Eric Harper <complex451@gmail.com>

* Prompt tuning bug fix (#3780)

* Making updated code backwards compatible with previous prompt tuned models

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Fixed backward compatiablity bug

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Removed random import

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* revert changes (#3785)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Fixed soft prompt eval loading bug (#3805)

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* mT5 whole word masking and T5 finetuning config fixes (#3776)

* O2 and whole word masking changes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update yaml

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Tok and O2 fix

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix arg passing

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix checkpoint path

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style fixes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Raise error if FP16 training is tried with O2 recipe. (#3806)

* raise error

Signed-off-by: ericharper <complex451@gmail.com>

* update assert

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove test

Signed-off-by: ericharper <complex451@gmail.com>

* revert bad merges

Signed-off-by: ericharper <complex451@gmail.com>

* revert change partitions

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
fayejf pushed a commit that referenced this pull request Mar 22, 2022
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* fix dockerfile (#3778)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Prompt-Tuning-Documentation (#3777)

* Update megatron.rst

* Updated example prompt tuning script's doc string

* Update megatron.rst

* Update megatron.rst

Co-authored-by: Eric Harper <complex451@gmail.com>

* Prompt tuning bug fix (#3780)

* Making updated code backwards compatible with previous prompt tuned models

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Fixed backward compatiablity bug

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Removed random import

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* revert changes (#3785)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Fixed soft prompt eval loading bug (#3805)

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* mT5 whole word masking and T5 finetuning config fixes (#3776)

* O2 and whole word masking changes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update yaml

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Tok and O2 fix

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix arg passing

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix checkpoint path

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style fixes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Raise error if FP16 training is tried with O2 recipe. (#3806)

* raise error

Signed-off-by: ericharper <complex451@gmail.com>

* update assert

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove test

Signed-off-by: ericharper <complex451@gmail.com>

* revert bad merges

Signed-off-by: ericharper <complex451@gmail.com>

* revert change partitions

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
fayejf pushed a commit that referenced this pull request Mar 22, 2022
* Tn bug 1.7.0 (#3730)

* fix es and fr bug

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* add file

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* [TTS] Fix bugs in E2E TTS, Mixer-TTS and FastPitch (#3740)

* fix bugs

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* fix bug in e2e tts and mixer tts

Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>

* Mirror AN4 data while servers are down (#3743)

Signed-off-by: smajumdar <titu1994@gmail.com>

* Bugfix for GPT eval  (#3744)

* use tokens_cut not tokens

Signed-off-by: ericharper <complex451@gmail.com>

* remove precision conversion and comment jit for bias gelu

Signed-off-by: ericharper <complex451@gmail.com>

* revert comment update mbs in config

Signed-off-by: ericharper <complex451@gmail.com>

* calculate micro_batch_size during complete and compute_logprobs

Signed-off-by: ericharper <complex451@gmail.com>

* ASR SSL update (#3746)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Fix SSL configs for 1.7 (#3748)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* punct process bug fix (#3747)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* updated conformer models. (#3741)

Signed-off-by: Vahid <vnoroozi@nvidia.com>

Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>

* Yuya/megatron t5 glue eval (#3751)

* Add megatron t5 glue eval-only script

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval default configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update megatron t5 glue eval configs

Signed-off-by: Yu Yao <yuya@nvidia.com>

* Update config comments

Signed-off-by: Yu Yao <yuya@nvidia.com>

Co-authored-by: Yu Yao <yuya@nvidia.com>

* Specify gpus in SSL notebook (#3753)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* Duplex model inference fix, money encoder fix (#3754)

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* Update docs for RNNT and overriding fused batch size (#3755)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix consumed samples calculation + PTune Model bugs (#3738)

* fix the way computing consumed samples

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fixed ptune model

Signed-off-by: Yi Dong <yidong@nvidia.com>

* make sure notebook is working

Signed-off-by: Yi Dong <yidong@nvidia.com>

* added try-catch

Signed-off-by: Yi Dong <yidong@nvidia.com>

Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>

* fix directories in ssl notebook (#3758)

* ssl update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* tutorial update

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* revert configs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* specify gpus

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* update dirs

Signed-off-by: sam1373 <samuelkriman@gmail.com>

* TN docs update (#3735)

* TN docs update: audio based docs added, quick start, ref fixed, etc

Signed-off-by: ekmb <ebakhturina@nvidia.com>

* add deployment script dir and Sp TN

Signed-off-by: ekmb <ebakhturina@nvidia.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>

* Update Tacotron2_Training.ipynb (#3769)

Signed-off-by: Jason <jasoli@nvidia.com>

* fix dockerfile (#3778)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Prompt-Tuning-Documentation (#3777)

* Update megatron.rst

* Updated example prompt tuning script's doc string

* Update megatron.rst

* Update megatron.rst

Co-authored-by: Eric Harper <complex451@gmail.com>

* Prompt tuning bug fix (#3780)

* Making updated code backwards compatible with previous prompt tuned models

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Fixed backward compatiablity bug

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* Removed random import

Signed-off-by: Virginia Adams <vadams@nvidia.com>

Co-authored-by: Eric Harper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* revert changes (#3785)

Signed-off-by: Yang Zhang <yangzhang@nvidia.com>

* Fixed soft prompt eval loading bug (#3805)

Signed-off-by: Virginia Adams <vadams@nvidia.com>

* mT5 whole word masking and T5 finetuning config fixes (#3776)

* O2 and whole word masking changes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Update yaml

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Tok and O2 fix

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix arg passing

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Fix checkpoint path

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Style fixes

Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca>

* Raise error if FP16 training is tried with O2 recipe. (#3806)

* raise error

Signed-off-by: ericharper <complex451@gmail.com>

* update assert

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update error message

Signed-off-by: ericharper <complex451@gmail.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* remove test

Signed-off-by: ericharper <complex451@gmail.com>

* revert bad merges

Signed-off-by: ericharper <complex451@gmail.com>

* revert change partitions

Signed-off-by: ericharper <complex451@gmail.com>

Co-authored-by: Yang Zhang <yzhang123@users.noreply.github.com>
Co-authored-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Samuel Kriman <samuelkriman@gmail.com>
Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com>
Co-authored-by: Vahid Noroozi <VahidooX@users.noreply.github.com>
Co-authored-by: yaoyu-33 <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <yuya@nvidia.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Co-authored-by: Micha Livne <michalivne@users.noreply.github.com>
Co-authored-by: Jason <jasoli@nvidia.com>
Co-authored-by: Virginia Adams <78445382+vadam5@users.noreply.github.com>
Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants