Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F2 aux override speedup #46

Merged
merged 11 commits into from
Aug 21, 2023
Merged

F2 aux override speedup #46

merged 11 commits into from
Aug 21, 2023

Conversation

calbaker
Copy link
Collaborator

@calbaker calbaker commented Aug 17, 2023 •
edited
Loading 

#[api(skip_get, skip_set)]
#[serde(skip)]
aux_in_kw_override: Option<Vec<f64>>,

that allows for a persistent array to eliminate the need for repeated cloning.

@calbaker calbaker requested a review from kylecarow August 17, 2023 21:02
@calbaker calbaker marked this pull request as draft August 17, 2023 21:02
@calbaker
made feature dev-proc-macros that determines whether local or publi…
b16590d 
…shed `fastsim-proc-macros` is used

demonstrated with `println!` that it works as expected
@calbaker
made feature dev-proc-macros that determines whether local or publi…
b11654f 
…shed `fastsim-proc-macros` is used

demonstrated with `println!` that it works as expected
@calbaker
removed debugging println
dd8a0f4
@calbaker
added new build script to use published version of fastsim-proc-macros
c821e9b
@calbaker
Merge branch 'f2-proc-macro-dep-fix' into f2-aux-override-speedup
1982e1b
@calbaker
pulled out arg to be assignment
b8b3a61
@calbaker
time.time => time.perf_counter
65bf975
@calbaker
removed print that should have been removed in previous commit but wa…
21611f5 
…s not somehow?
@calbaker
this shows that the new method of setting aux_in_override is maybe 25…
c0f12f9 
…% faster

and is somehow faster than not providing the array
@calbaker calbaker marked this pull request as ready for review August 18, 2023 20:40
@calbaker
Copy link
Collaborator Author

@kylecarow , this is ready for review

@kylecarow kylecarow merged commit 563c441 into fastsim-2 Aug 21, 2023
@kylecarow kylecarow deleted the f2-aux-override-speedup branch August 21, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarow kylecarow kylecarow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calbaker @kylecarow