Pin the actual recipe revisions for all conan dependencies #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pro: we have zero chance of pulling something else. Fully reproducible builds Cons: whenever we want to update a dependency, we'll have to bump the revision in OpenStudio/ConanInstall.cmake If we do not pin dependencies, we could simply upload a new recipe revision, and delete the old one from the remote, or pass UPDATE to conan cmake run. I don't like passing UPDATE to conan_cmake_run actually because it has to query bintray for changes everytime you run cmake (which takes time, doesn't work offline, etc) Note: the pinning of deps really matter a lot of openstuido_ruby but not so much for the rest of the deps. Because we're unlikely going to bump a dep like boost for no reason without also bumping the version (eg boost/1.74...)
jmarrec
added
Pull Request - Ready for CI
jmarrec
commented
Aug 15, 2020
|
@tijcolem we'll have to wipe the entire conan cache on the build agents) to make this work, because there are conflicts with the packages already there BEFORE the |
jmarrec
commented
Aug 15, 2020
…see if we can find the right revisions in case we have some revisions already and they don't match. Too bad.
|
CI Results for 0230125:
|
|
Mac is just failing because of the usual suspect (cf #4043) |
|
I cleared the ~/.conan/data on the remote agents and replayed the CI. It sounds like this may not have been necessary due to your recent change using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pro: we have zero chance of pulling something else. Fully reproducible builds
Cons: whenever we want to update a dependency, we'll have to bump the revision in OpenStudio/ConanInstall.cmake
If we do not pin dependencies, we could simply upload a new recipe revision, and delete the old one from the remote, or pass UPDATE to conan cmake run. I don't like passing UPDATE to conan_cmake_run actually because it has to query bintray for changes everytime you run cmake (which takes time, doesn't work offline, etc)
Note: the pinning of deps really matter a lot of openstuido_ruby but not so much for the rest of the deps. Because we're unlikely going to bump a dep like boost for no reason without also bumping the version (eg boost/1.74...)