Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or disable failing unit tests #4043

Closed
3 tasks
jmarrec opened this issue Aug 12, 2020 · 1 comment · Fixed by #4145
Closed
3 tasks

Fix or disable failing unit tests #4043

jmarrec opened this issue Aug 12, 2020 · 1 comment · Fixed by #4145

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Aug 12, 2020

Issue overview

At least these tests are failing sometimes (but often enough to be really annoying). They should be fixed or disabled.

  • EnergyPlusFixture.ForwardTranslatorTest_MultiThreadedLogMessages (Failed):
  • BCLFixture: I think this looks like a timeout issue from web requests... they fail after 60s of not completing. May be a firewall thing.
    • BCLFixture.RemoteBCLTest (SIGTRAP)
    • BCLFixture.GetComponentByUID (SIGTRAP)

@kbenne @joseph-robertson @tijcolem seen any other?

The list of tests that CI has filtered out is this FYI:

  failingTests = [
    'ModelFixture.Space_intersectSurfaces_degenerate1',
    'ModelFixture.Space_intersectSurfaces_degenerate2',
    'ModelFixture.Space_intersectSurfaces_degenerate3',
    'ModelFixture.ThreeJSReverseTranslator_FloorplanJS_SimAUD_Paper',
    'CLITest-test_encodings-encoding',
    'CLITest-test_encodings-encoding2'
  ];

Details

616/3011 Testing: BCLFixture.GetComponentByUID
616/3011 Test: BCLFixture.GetComponentByUID
Command: "/Users/jenkins/git/OpenStudioIncremental/develop/build/Products/openstudio_utilities_tests" "--gtest_filter=BCLFixture.GetComponentByUID"
Directory: /Users/jenkins/git/OpenStudioIncremental/develop/build/src/utilities
"BCLFixture.GetComponentByUID" start time: Aug 12 05:22 MDT
Output:
----------------------------------------------------------
Running main() from gmock_main.cc
Note: Google Test filter = BCLFixture.GetComponentByUID
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from BCLFixture
[ RUN      ] BCLFixture.GetComponentByUID
/Users/jenkins/git/OpenStudioIncremental/develop/src/utilities/bcl/test/BCL_GTest.cpp:327: Failure
Value of: component
  Actual: false
Expected: true
<end of output>
Test time =  60.19 sec
----------------------------------------------------------
Test Failed.
"BCLFixture.GetComponentByUID" end time: Aug 12 05:23 MDT
"BCLFixture.GetComponentByUID" time elapsed: 00:01:00
----------------------------------------------------------
614/3011 Testing: BCLFixture.RemoteBCLTest
614/3011 Test: BCLFixture.RemoteBCLTest
Command: "/Users/jenkins/git/OpenStudioIncremental/develop/build/Products/openstudio_utilities_tests" "--gtest_filter=BCLFixture.RemoteBCLTest"
Directory: /Users/jenkins/git/OpenStudioIncremental/develop/build/src/utilities
"BCLFixture.RemoteBCLTest" start time: Aug 12 05:22 MDT
Output:
----------------------------------------------------------
Running main() from gmock_main.cc
Note: Google Test filter = BCLFixture.RemoteBCLTest
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from BCLFixture
[ RUN      ] BCLFixture.RemoteBCLTest
/Users/jenkins/git/OpenStudioIncremental/develop/src/utilities/bcl/test/BCL_GTest.cpp:129: Failure
Value of: completed
  Actual: false
Expected: true
<end of output>
Test time =  61.36 sec
----------------------------------------------------------
Test Failed.
"BCLFixture.RemoteBCLTest" end time: Aug 12 05:23 MDT
"BCLFixture.RemoteBCLTest" time elapsed: 00:01:01
----------------------------------------------------------

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): all
  • Version of OpenStudio (if using an intermediate build, include SHA): a6b3e86 (3.1.0-alpha)

Context

Jenkins CI reporting failed runs because of this.

@tijcolem
Copy link
Collaborator

I think we can swap BCL components to make this faster to download. For some reason, some components can take over 3 min to download. The one in our test suite is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants