Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stratified tank bugfix #1849

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Stratified tank bugfix #1849

merged 3 commits into from
Oct 4, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 4, 2024 •
edited
Loading

Pull Request Description

Closes #1847 and closes #1848.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added bug Something isn't working refactor labels Oct 4, 2024
@shorowit shorowit self-assigned this Oct 4, 2024
@shorowit
Copy link
Contributor Author

shorowit commented Oct 4, 2024

Tiny diffs for HPWHs and stratified tank ERWHs.

@shorowit shorowit requested a review from jmaguire1 October 4, 2024 18:52
jmaguire1
jmaguire1 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@jmaguire1 jmaguire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for doing this so quickly Scott!

@shorowit shorowit merged commit 745026f into master Oct 4, 2024
@shorowit shorowit deleted the stratified_tank_bugfix branch October 4, 2024 20:49
@joseph-robertson joseph-robertson mentioned this pull request Oct 7, 2024
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaguire1 jmaguire1 jmaguire1 approved these changes

Assignees

@shorowit shorowit

Labels
bug Something isn't working refactor
Projects
OpenStudio-HPXML
Archived in project
Milestone
No milestone
2 participants
@shorowit @jmaguire1