Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat pump switchover/lockout temperatures #1273

Merged
merged 24 commits into from
Feb 3, 2023
Merged

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Jan 20, 2023

Pull Request Description

Heat pump enhancements:

  • Allows CompressorLockoutTemperature as an optional input to control the minimum temperature the compressor can operate at.
  • Updates defaults for CompressorLockoutTemperature and BackupHeatingLockoutTemperature.
  • Provides a warning if BackupHeatingSwitchoverTemperature or BackupHeatingLockoutTemperature are low and may cause unmet hours.
  • Fixes BackupHeatingSwitchoverTemperature for a heat pump w/ separate backup system; now correctly ceases backup operation above this temperature.

Closes #1270.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

…o heat_pump_temperatures

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
@shorowit
Copy link
Contributor Author

shorowit commented Jan 24, 2023

Using EMS to allow BackupHeatingSwitchoverTemperature or BackupHeatingLockoutTemperature for a HP separate backup system...

Before vs after for a value of 10F:

image

shorowit and others added 8 commits January 24, 2023 14:46
…dio-HPXML into heat_pump_temperatures

# Conflicts:
#	HPXMLtoOpenStudio/tests/test_hvac.rb
#	tasks.rb
#	workflow/sample_files/base-hvac-air-to-air-heat-pump-1-speed-lockout-temperatures.xml
#	workflow/sample_files/base-hvac-dual-fuel-air-to-air-heat-pump-1-speed-lockout-temperatures.xml
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
@shorowit shorowit changed the base branch from master to update_sample_files January 25, 2023 19:49
Base automatically changed from update_sample_files to master January 25, 2023 22:36
@shorowit shorowit marked this pull request as ready for review January 25, 2023 23:22
shorowit and others added 5 commits January 25, 2023 16:28
…o heat_pump_temperatures

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@shorowit shorowit merged commit 6fd9928 into master Feb 3, 2023
@shorowit shorowit deleted the heat_pump_temperatures branch February 3, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heat pump switchover/lockout temperatures
1 participant