Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSHP and ASHP modeling consistency #1244

Merged
merged 80 commits into from
May 17, 2023
Merged

MSHP and ASHP modeling consistency #1244

merged 80 commits into from
May 17, 2023

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Dec 6, 2022 •
edited by shorowit
Loading

Pull Request Description

To align mshp and var speed ashp modeling approach, following changes are made on this PR:

  • Crankcase power consumption is changed to be 50 watts as default for both systems,
  • Allow user input for crankcase power consumption,
  • Allow user input for compressor lockout temperature Heat pump switchover/lockout temperatures #1273
  • heat c_d is changed to be 0.25 for all variable speed systems,
  • rated cfm/ton equations
  • rated cfm/ton assumed values
  • sensible heat ratio (shr)

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Unit tests have been added/updated (e.g., HPXMLtoOpenStudio/tests)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

yzhou601 and others added 12 commits January 3, 2023 19:40
@yzhou601
allow crankcase watts to be user input
5d24ccc
@yzhou601
Merge branch 'mshp_ashp' of https://github.com/NREL/OpenStudio-HPXML …
e8b7604 
…into mshp_ashp
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
afd409c 
…o mshp_ashp
Latest results.
c8b77ed
@yzhou601
change the cfm/ton to be the same at max speed, keeping mshp approach
4132b6c
@yzhou601
Merge branch 'mshp_ashp' of https://github.com/NREL/OpenStudio-HPXML …
7e1099c 
…into mshp_ashp
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
923e060 
…o mshp_ashp
Latest results.
004e1df
@yzhou601
implement the same cfm per ton for mshp cooling
05ff6e8
@yzhou601
Merge branch 'mshp_ashp' of https://github.com/NREL/OpenStudio-HPXML …
4c14208 
…into mshp_ashp
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
eeccf10 
…o mshp_ashp
Latest results.
bf6cfc5
@yzhou601
Copy link
Collaborator Author

yzhou601 commented Feb 2, 2023

The changes made to minisplit cooling systems didn't impact the results except for some rounding diffs caused by the hardcoded ratios. Will do the same combinations for heating (even though I will not change the rated air flow values for heating in the next step until we are more confident with the assumptions).
The minisplit systems are still calculating 10 speeds for now, it is because even though we can hardcode just 4 speeds for cfm/ton, capacity ratios, fan speed ratios, and calculated shrs, current efficiency methods still assume 10 speeds and use those variables, I'll need more investigation to see if efficiencies can be calculated only for 4 speeds too.

yzhou601 and others added 7 commits May 4, 2023 18:22
@yzhou601
parse all error lines for warning
8477529
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
087d34b 
…o mshp_ashp

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hpxml.rb
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
Latest results.
f7e9148
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
16afc98 
…o mshp_ashp

# Conflicts:
#	BuildResidentialHPXML/measure.xml
#	HPXMLtoOpenStudio/measure.xml
#	HPXMLtoOpenStudio/resources/hpxml.rb
#	HPXMLtoOpenStudio/tests/test_defaults.rb
#	docs/source/workflow_inputs.rst
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
Latest results.
354fb4b
@shorowit
Fix merge.
ed8b1a2
@shorowit
Merge branch 'mshp_ashp' of https://github.com/NREL/OpenStudio-HPXML …
c69e595 
…into mshp_ashp
shorowit
shorowit reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final comments from me.

workflow/sample_files/base-hvac-crankcase-40w.xml Outdated Show resolved Hide resolved
BuildResidentialHPXML/measure.rb Outdated Show resolved Hide resolved
@shorowit
Copy link
Contributor

@jonwinkler is looking into improvements in the generalized SHR model. Once we have that, this should be good to go.

shorowit and others added 9 commits May 16, 2023 16:26
@shorowit
Catch unexpected severe (or even fatal) messages in CI tests too. Rem…
b3020b8 
…ove duplicate hard-coded cfm/ton values; fixes MSHP severe messages.
Latest results.
35c9aa6
@yzhou601
hardcode humidity ratio
8f03baf
@yzhou601
Merge branch 'mshp_ashp' of https://github.com/NREL/OpenStudio-HPXML …
7e8f34c 
…into mshp_ashp
@yzhou601
remove warning
66993d9
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
44074b9 
…o mshp_ashp
Latest results.
2f990a9
@shorowit
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
32f4dbe 
…o mshp_ashp

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results.csv
#	workflow/tests/base_results/results_bills.csv
#	workflow/tests/hpxml_translator_test.rb
@shorowit
Update changelog, minor changes. [ci skip]
940aa5e
shorowit
shorowit approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will merge once the CI comes back with a ✔️.

Thanks for all the good work here, @yzhou601 (and @jonwinkler)!

@shorowit shorowit merged commit 5e2ee74 into master May 17, 2023
@shorowit shorowit deleted the mshp_ashp branch May 17, 2023 23:51
@joseph-robertson joseph-robertson mentioned this pull request May 19, 2023
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

@jonwinkler jonwinkler Awaiting requested review from jonwinkler

Assignees

@yzhou601 yzhou601

Labels
refactor
Projects
OpenStudio-HPXML
Archived in project
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yzhou601 @shorowit @jonwinkler