-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect "other" row ABUPS end-used by subcategory table #7794
Conversation
Note: the branch for this pull request was copied from another branch to rectify some GitHub weirdness. The original PR was #7693 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested defect file and confirmed fix. Ran unit tests locally.
Merged in develop and resolved yet another conflict.
Will wait for CI results before merging - want to confirm that the extra meters are slowing things down.
The same three files are "failing" which are as expected. |
@JasonGlazer Thanks. I'm waiting on a full set of CI results before merging. Primarily to be sure the extra meters aren't causing a slowdown in performance. |
Very small performance penalty, I'm not sure it's worth investigating at the moment. You can open up a ticket to follow-up on this and try to optimize some code to balance the penalty back out after freeze if you want. |
And it looks like the format checker errors are all from the coil refactor? Nor related to this PR. |
Pull request overview
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.