Skip to content

Commit

Permalink
Rolling back original fix.
Browse files Browse the repository at this point in the history
  • Loading branch information
JasonGlazer committed Jan 22, 2020
1 parent 17892c0 commit 14c8b0d
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/EnergyPlus/OutputProcessor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2251,8 +2251,8 @@ namespace OutputProcessor {
}

// End use subcategory
// if (!EndUseSub.empty() && !UtilityRoutines::SameString(EndUseSub,"General")) { // attempted fix for 7556 but probably not the right approach
if (!EndUseSub.empty()) {
// if (!EndUseSub.empty() && !UtilityRoutines::SameString(EndUseSub, "General")) {
if (!EndUseSub.empty()) {
Found = UtilityRoutines::FindItem(EndUseSub + ':' + EndUse + ':' + ResourceType, EnergyMeters);
if (Found != 0) {
++VarMeterArrays(NumVarMeterArrays).NumOnMeters;
Expand Down Expand Up @@ -5644,8 +5644,7 @@ void SetupOutputVariable(std::string const &VariableName, // String Na
EndUseSub = EndUseSubKey;
OnMeter = true;
} else {
// EndUseSub = "General"; // attempted fix for 7556 but probably not the right approach
EndUseSub = "";
EndUseSub = "General";
}
if (present(GroupKey)) {
Group = GroupKey;
Expand Down

7 comments on commit 14c8b0d

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4: OK (2644 of 2656 tests passed, 674 test warnings)

Messages:\n

  • 677 tests had: AUD diffs.
  • 677 tests had: ERR diffs.
  • 663 tests had: MDD diffs.
  • 677 tests had: MTD diffs.
  • 1 test had: BND diffs.
  • 1 test had: Table big diffs.
  • 2 tests had: JSON big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 764
  • Failed: 6

IHPFixture Test Summary

  • Passed: 5
  • Failed: 1

regression Test Summary

  • Passed: 690
  • Failed: 3

WaterThermalTanksFixture Test Summary

  • Passed: 19
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-cppcheck: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-custom_check: OK (11 of 11 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-UnitTestsCoverage-Debug: OK (1259 of 1268 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 764
  • Failed: 6

IHPFixture Test Summary

  • Passed: 5
  • Failed: 1

WaterThermalTanksFixture Test Summary

  • Passed: 19
  • Failed: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-MacOS-10.13-clang: OK (2604 of 2616 tests passed, 670 test warnings)

Messages:\n

  • 673 tests had: AUD diffs.
  • 673 tests had: ERR diffs.
  • 659 tests had: MDD diffs.
  • 673 tests had: MTD diffs.
  • 1 test had: BND diffs.
  • 1 test had: Table big diffs.
  • 2 tests had: JSON big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 764
  • Failed: 6

IHPFixture Test Summary

  • Passed: 5
  • Failed: 1

regression Test Summary

  • Passed: 670
  • Failed: 3

WaterThermalTanksFixture Test Summary

  • Passed: 19
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - x86_64-Linux-Ubuntu-18.04-gcc-7.4-IntegrationCoverage-Debug: OK (677 of 678 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 677
  • Timeout: 1

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7556b-other-end-use-subcat-try2 (JasonGlazer) - Win64-Windows-10-VisualStudio-16: OK (2604 of 2616 tests passed, 670 test warnings)

Messages:\n

  • 673 tests had: AUD diffs.
  • 673 tests had: ERR diffs.
  • 659 tests had: MDD diffs.
  • 673 tests had: MTD diffs.
  • 1 test had: BND diffs.
  • 1 test had: Table big diffs.
  • 2 tests had: JSON big diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 764
  • Failed: 6

IHPFixture Test Summary

  • Passed: 5
  • Failed: 1

regression Test Summary

  • Passed: 670
  • Failed: 3

WaterThermalTanksFixture Test Summary

  • Passed: 19
  • Failed: 1

Build Badge Test Badge

Please sign in to comment.