Draft: Combine multiple ElectronicFrictionProviders (or Models) into a single model.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A CompositeModel combines multiple models assigned to determine parts of the total system, e.g. different friction processes for different parts of the system. The Subsystem type is the building block of a CompositeModel, combining an arbitrary NQCModels.Model with indices determining which particles in the system it applies to.
This is so they are included as possible inputs for a Subsystem.
Or not Another try Debug Tried to break the stack overflow
Need to call friction! and derivative! for subsystems and full R I am very confused
This was referenced Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phonon thermostatting in NQCD
Implements MDEF + 2TM with Phonon coupling (NQCD/NQCDynamics.jl#73) by introducing
Subsystems, which apply aModelexclusively to certain atoms in aSimulation. These can be combined arbitrarily forModeltypes implementingpotential,derivativeorfriction.The changes to
Simulations in NQCD/NQCDynamics.jl#349 allow the use of different temperatures (either a constant value or function) for each atom by usingThermostats, which behave like aSubsystem, applying a temperature to parts of aSimulation.ToDo