Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement inverse transformation into input space #11

Merged
merged 15 commits into from
Aug 12, 2022

Conversation

1-w
Copy link

@1-w 1-w commented Aug 4, 2022

automatically creates predictions transformed back to input t1 and flair space

simple solution that works with the "Affine" choice for registration.

@1-w
Copy link
Author

1-w commented Aug 4, 2022

possible solution to #8

@ravnoor
Copy link
Contributor

ravnoor commented Aug 4, 2022

This is great - thanks for contributing!

It looks like you used a code formatting tool introducing more changes than the intent of the commit. Would it be possible to separate these two changes (inverse transformation and code formatting) into two separate commits?

I should then be able to review the changes and merge the PR.

@ravnoor ravnoor linked an issue Aug 4, 2022 that may be closed by this pull request
@ravnoor ravnoor added the enhancement New feature or request label Aug 4, 2022
- separate transformation functionality from code formatting
ravnoor added a commit to NOEL-MNI/deepMask that referenced this pull request Aug 8, 2022
- for consistent and self-explanatory naming in NOEL-MNI/deepFCD#11
@ravnoor ravnoor changed the title merged with inverse transformation into input space implement inverse transformation into input space Aug 12, 2022
@ravnoor ravnoor merged commit d03d8bc into NOEL-MNI:main Aug 12, 2022
@ravnoor
Copy link
Contributor

ravnoor commented Aug 12, 2022

Reviewed the code, made the necessary changes, and tested the pipeline to ensure it runs as intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output predictions in structural space
2 participants