Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compression options for high res history files #3178

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

CatherineThomas-NOAA
Copy link
Contributor

Description

Different compression options are applied for the high resolution history files. The value of quantize_nsd will be different depending on the value of quantize_mode, so a fix is required to obtain the same behavior as the v16 compression options.

Resolves: #3129

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

C384/C192 ATM-only cycled experiment on Hera. Results documented in #3129

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Compression options are applied for the high resolution
history files. The value of quantize_nsd will change
depending on the value of quantize_mode, so a fix is
required to obtain the same behavior as the v16
compression options.

Resolves: NOAA-EMC#3129
@aerorahul aerorahul merged commit 2595e60 into NOAA-EMC:develop Dec 18, 2024
4 of 5 checks passed
@CatherineThomas-NOAA CatherineThomas-NOAA deleted the bugfix/quantize branch December 19, 2024 13:55
CatherineThomas-NOAA added a commit to CatherineThomas-NOAA/global-workflow that referenced this pull request Dec 20, 2024
Different compression options are applied for the high resolution
history files. The value of quantize_nsd will be different
depending on the value of quantize_mode, so a fix is required
to obtain the same behavior as the previous compression options.
This option needs to be updated for both GFS and GEFS.

Resolves: NOAA-EMC#3178
aerorahul pushed a commit that referenced this pull request Dec 20, 2024
# Description
Different compression options are applied for the high resolution
history files. The value of quantize_nsd will be different depending on
the value of quantize_mode, so a fix is required to obtain the same
behavior as the previous compression options. This option needs to be
updated for both GFS and GEFS.

Resolves: #3178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atm history files incorrectly written with new compression options
2 participants