Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocnanalbmat #1286

Merged

Conversation

AndrewEichmann-NOAA
Copy link
Contributor

Description

This adds the ocnanalbmat task to S2S workflow between ocnanalprep and ocnanalrun.

At present this is a stub task that does not actually run the associated jjob, pending more extensive testing

Partially addresses issue NOAA-EMC/GDASApp#263

Files changed:
env/HERA.env
env/ORION.env
parm/config/config.resources
workflow/applications.py
workflow/rocoto/workflow_tasks.py

Files added:
jobs/rocoto/ocnanalbmat.sh
parm/config/config.ocnanalbmat

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with abbreviated cycled ocean analysis run on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [] My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@AndrewEichmann-NOAA
Copy link
Contributor Author

@guillaumevernieres FYI

jobs/rocoto/ocnanalbmat.sh Fixed Show fixed Hide fixed
jobs/rocoto/ocnanalbmat.sh Fixed Show fixed Hide fixed
jobs/rocoto/ocnanalbmat.sh Fixed Show fixed Hide fixed
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just a minor comment about removing your edit for ocnpost .

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewEichmann-NOAA
Copy link
Contributor Author

@guillaumevernieres Who in charge of g-w should review this?

Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to WCOSS2.env in addition to HERA and ORION.

workflow/rocoto/workflow_tasks.py Show resolved Hide resolved
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of exclusive is incorrect.

workflow/rocoto/workflow_tasks.py Show resolved Hide resolved
parm/config/config.resources Outdated Show resolved Hide resolved
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now.
Thanks.

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title adding ocnanalbmat to workflow Add ocnanalbmat Jan 31, 2023
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 32b2169 into NOAA-EMC:develop Jan 31, 2023
@AndrewEichmann-NOAA
Copy link
Contributor Author

Thank you!

@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the feature/soca-cycled branch January 31, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants