Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upp submodule #811

Merged
merged 19 commits into from
Apr 19, 2024
Merged

Update upp submodule #811

merged 19 commits into from
Apr 19, 2024

Conversation

WenMeng-NOAA
Copy link
Contributor

@WenMeng-NOAA WenMeng-NOAA commented Mar 28, 2024

Description

This PR is for updating upp submodule with recent changes from UPP repository which include Rocky8 transition on Hera and GFS HR4 support.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@DusanJovic-NOAA
Copy link
Collaborator

@WenMeng-NOAA Could you merge #805 into this PR? PR #805 modifies only one file (.github/workflows/GCC.yml).

@WenMeng-NOAA
Copy link
Contributor Author

@WenMeng-NOAA Could you merge #805 into this PR? PR #805 modifies only one file (.github/workflows/GCC.yml).

@DusanJovic-NOAA Merged in my FV3 branch upp_HR4

@DusanJovic-NOAA
Copy link
Collaborator

@WenMeng-NOAA Could you merge #805 into this PR? PR #805 modifies only one file (.github/workflows/GCC.yml).

@DusanJovic-NOAA Merged in my FV3 branch upp_HR4

Thanks.

@zach1221
Copy link
Collaborator

@jkbk2004 we have approvals and are ready to merge here.

@jkbk2004 jkbk2004 merged commit da95cc4 into NOAA-EMC:develop Apr 19, 2024
2 of 6 checks passed
zhanglikate added a commit to zhanglikate/fv3atm that referenced this pull request May 3, 2024
commit da95cc4
Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com>
Date:   Fri Apr 19 12:36:43 2024 -0400

    Update upp submodule (NOAA-EMC#811)

    * Update github workflow. Update gcc to 12 and mpi to openmpi

    * Add 'spack clean' to reduce the size of the cache files

    * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm

    * Update github workflow. Add mpich

    * Update github actions to v4

    * Use action/cache/restore in build_fv3atm job

    * update upp revision to 5faac75

    * Update GCC.yml

    ---------

    Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>

commit 979bcab
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Wed Apr 17 13:42:06 2024 -0400

    Update dycore to remove compiler warnings (NOAA-EMC#813)

    * Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore

    * Pass correct mpi communicator type to post_alctvars routine in inline post

commit 37e7d48
Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com>
Date:   Sun Apr 14 13:00:07 2024 -0400

    bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (NOAA-EMC#806)

    * nesting fixes
    1. Initialize hailwat index in dynamical core.
    2. Use the correct tile number for nests in atmos_model.F90.

    * remove unneeded write statements

    * Fix kchunk3d in io/module_write_netcdf.F90

    ---------

    Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>

commit 383687e
Author: JONG KIM <jong.kim@noaa.gov>
Date:   Thu Apr 4 16:34:52 2024 -0400

    cubed_sphere hash fix to f060e85 (NOAA-EMC#817)

    * Update cubed_sphere@f060e85 hash: a bug fix in the HAILCAST diagnostic code (units issue)

commit 1cac9d3
Author: Denise Worthen <denise.worthen@noaa.gov>
Date:   Wed Apr 3 16:48:31 2024 -0400

    Enable cpl_scalars (NOAA-EMC#794)

    * add cpl_scalars for atm

    * add field cpl_scalars to export state of fv3atm when coupled.
    cpl_scalars contain the dimensions of the fv3atm domain and are
    used by cmeps to write mediator history files as a single 2d
    grid for regional and 6 2d grids for CSG.

    * remove unused NUOPC use statement

commit 1b75fe2
Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com>
Date:   Mon Apr 1 17:12:08 2024 -0400

    Update module_write_netcdf to avoid hangs in RRFS runs (NOAA-EMC#803)

    * Split add_dim into two routines

    * Add NF90_NODIMSCALE_ATTACH constant

    * Test classic netcdf file formats

commit 1ba8410
Author: lisa-bengtsson <54411948+lisa-bengtsson@users.noreply.github.com>
Date:   Wed Mar 27 12:12:00 2024 -0600

    Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. (NOAA-EMC#799)

    * Update ccpp/physics for namelist flag xr_cnvcld
This was referenced May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update upp submodule
5 participants