Update module_write_netcdf to avoid hangs in RRFS runs #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
SamuelTrahanNOAA
approved these changes
Mar 27, 2024
BrianCurtis-NOAA
approved these changes
Apr 1, 2024
|
@jkbk2004 testing is complete on WM PR #2193. Can you please review is this PR, and merge, if possible? |
Oh, ok noted. Thanks for confirming, Brian. |
jkbk2004
approved these changes
Apr 1, 2024
zhanglikate
added a commit
to zhanglikate/fv3atm
that referenced
this pull request
May 3, 2024
commit da95cc4 Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Date: Fri Apr 19 12:36:43 2024 -0400 Update upp submodule (NOAA-EMC#811) * Update github workflow. Update gcc to 12 and mpi to openmpi * Add 'spack clean' to reduce the size of the cache files * Split GCC.yml workflow into two jobs, build_spack and build_fv3atm * Update github workflow. Add mpich * Update github actions to v4 * Use action/cache/restore in build_fv3atm job * update upp revision to 5faac75 * Update GCC.yml --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> commit 979bcab Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Date: Wed Apr 17 13:42:06 2024 -0400 Update dycore to remove compiler warnings (NOAA-EMC#813) * Update atmos_cubed_sphere and add compile definition BYPASS_BREED_SLP_INLINE to dycore * Pass correct mpi communicator type to post_alctvars routine in inline post commit 37e7d48 Author: Samuel Trahan (NOAA contractor) <39415369+SamuelTrahanNOAA@users.noreply.github.com> Date: Sun Apr 14 13:00:07 2024 -0400 bug fixes: kchunk3d ignored, hailwat uninitialized in dycore, tile_num wrong for nests (NOAA-EMC#806) * nesting fixes 1. Initialize hailwat index in dynamical core. 2. Use the correct tile number for nests in atmos_model.F90. * remove unneeded write statements * Fix kchunk3d in io/module_write_netcdf.F90 --------- Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> commit 383687e Author: JONG KIM <jong.kim@noaa.gov> Date: Thu Apr 4 16:34:52 2024 -0400 cubed_sphere hash fix to f060e85 (NOAA-EMC#817) * Update cubed_sphere@f060e85 hash: a bug fix in the HAILCAST diagnostic code (units issue) commit 1cac9d3 Author: Denise Worthen <denise.worthen@noaa.gov> Date: Wed Apr 3 16:48:31 2024 -0400 Enable cpl_scalars (NOAA-EMC#794) * add cpl_scalars for atm * add field cpl_scalars to export state of fv3atm when coupled. cpl_scalars contain the dimensions of the fv3atm domain and are used by cmeps to write mediator history files as a single 2d grid for regional and 6 2d grids for CSG. * remove unused NUOPC use statement commit 1b75fe2 Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Date: Mon Apr 1 17:12:08 2024 -0400 Update module_write_netcdf to avoid hangs in RRFS runs (NOAA-EMC#803) * Split add_dim into two routines * Add NF90_NODIMSCALE_ATTACH constant * Test classic netcdf file formats commit 1ba8410 Author: lisa-bengtsson <54411948+lisa-bengtsson@users.noreply.github.com> Date: Wed Mar 27 12:12:00 2024 -0600 Introduce namelist flag xr_cnvcld to control if suspended grid-mean convective cloud condensate should be included in cloud fraction and optical depth calculation in radiation in the GFS suite. (NOAA-EMC#799) * Update ccpp/physics for namelist flag xr_cnvcld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write grid component hangs in write_netcdf routine with planned operational RRFS configuration. See details here (ufs-community/ufs-weather-model#2174)
This PR updates write_netcdf by passing NF90_NODIMSCALE_ATTACH flag to nf90_create routine, which disables attaching dimscales which is the part of the netcdf code where errors are occurring.
Additionally the routine that currently both defines and writes coordinate variables is split into two in order to avoid ending define mode and reentering again several times unnecessarily.
Several unused variables were removed. Code cleanup.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested? RRFS test cases on Hera/Jet and WCOSS2. Will run regression test soon.
What compilers / HPCs was it tested with? Intel and GNU. Hera, Jet, WCOSS2
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Not yet.
Will the code updates change regression test baseline? No
Dependencies
N/A