Urgent bug fix: libIFI changes broke inline post due to missing deallocates #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamuelTrahanNOAA Do you have an UPP issue for this PR? If not, please create one. |
It is #622 |
WenMeng-NOAA
added
No Baseline Change
|
The UPP RT tests were completed on Hera and Orion. No baseline update is needed for this PR. |
WenMeng-NOAA
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My changes to connect libIFI to the post do not deallocate some arrays after each iteration of libpost. This causes the model to abort at runtime due to allocating an array that is already allocated.
Fixes #622
This has been applied to #620 as well, but I strongly recommend this PR be merged first.