Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSL UPP developments up to January 2023 #620

Merged
merged 7 commits into from
Jan 31, 2023

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jan 26, 2023

  1. Increases precision of VIL_ON_ENTIRE_ATMOS from <scale>4.0</scale> to <scale>7.0</scale>
  2. Adds an experimental diagnostic, developed for the HRRR to correct for the HRRR's low bias in cloud cover. For an FAA deliverable due Feb 2023.
  3. Able to use either cldfra or cldfra_bl when reading cloud fraction from INITPPOST_NETCDF. (Will use whichever is available; uses cldfra if both are present.)

The GSL in-flight icing developments were merged in pull requests #536 and #621

Fixes #610

1. Increases precision of VIL_ON_ENTIRE_ATMOS from `<scale>4.0</scale>` to `<scale>7.0</scale>`
2. Adds an experimental diagnostic, developed for the HRRR to correct for the HRRR's low bias in cloud cover. For an FAA deliverable due Feb 2023.
3. Switches from cldfra to cldfra_bl when reading cloud fraction from INITPPOST_NETCDF
@SamuelTrahanNOAA
Copy link
Contributor Author

These changes were from @EricJames-NOAA and @hu5970

@EricJames-NOAA
Copy link
Contributor

@SamuelTrahanNOAA thanks!

Regarding change (3), I don't understand why EMC reads in a different field for cloud fraction from FV3. GSL has always had cldfra_bl output. We may need to ask other developers about this.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA thanks!

Regarding change (3), I don't understand why EMC reads in a different field for cloud fraction from FV3. GSL has always had cldfra_bl output. We may need to ask other developers about this.

@yangfanglin and @ericaligo-NOAA Could you confirm if EMC side has switched cloud fraction model output from cldfra to cldfra_bl for RRFS?

@ericaligo-NOAA
Copy link
Contributor

ericaligo-NOAA commented Jan 27, 2023 via email

@SamuelTrahanNOAA
Copy link
Contributor Author

SamuelTrahanNOAA commented Jan 27, 2023

I've merged the bug fix from #621 that is needed to get the inline post working again, after my libIFI changes broke it. (I don't deallocate some arrays after the next iteration of the post.) If this PR will take a while to review, then we should merge #621 first since it'll be a shoo-in.

EDIT: The bug fix in #621 has been merged.

@SamuelTrahanNOAA
Copy link
Contributor Author

The bug fix in #621 has been merged to develop, and I've synced this branch with develop again.

@WenMeng-NOAA
Copy link
Collaborator

@EricJames-NOAA From the UPP RT tests on Hera, there are following changed results in rap/hrrr:

[Wen.Meng@hfe07 ~/stmp2]$ cat rap_2020072316/WRFPRS.GrbF16.diff
697:190713718:HGT:cloud base:rpn_corr=0.895998:rpn_rms=3364.31
698:191867295:PRES:cloud base:rpn_corr=0.91432:rpn_rms=15296.7
708:195473891:CDCON:convective cloud layer:rpn_corr=-nan:rpn_rms=undefined
[Wen.Meng@hfe07 ~/stmp2]$ cat rap_2020072316/WRFNAT.GrbF16.diff
1070:282595626:HGT:cloud base:rpn_corr=0.895998:rpn_rms=3364.31
1071:283749203:PRES:cloud base:rpn_corr=0.91432:rpn_rms=15296.7
[Wen.Meng@hfe07 ~/stmp2]$ cat hrrr_2020060118/WRFTWO.GrbF04.diff
121:85620587:HGT:cloud base:rpn_corr=0.932971:rpn_rms=2896.63
122:88068643:PRES:cloud base:rpn_corr=0.931465:rpn_rms=12453.8

I would assume these changes come from updates in CLDRAD.f?

Now I saw valid cloud fraction in GSL RRFS test at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_rrfs_2022102713.
Would you please verify my testing? Thanks!

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Would you add change logs in two source code files CLDRAD.f and INITPOST_NETCDF.f?

@EricJames-NOAA
Copy link
Contributor

@EricJames-NOAA From the UPP RT tests on Hera, there are following changed results in rap/hrrr:

[Wen.Meng@hfe07 ~/stmp2]$ cat rap_2020072316/WRFPRS.GrbF16.diff
697:190713718:HGT:cloud base:rpn_corr=0.895998:rpn_rms=3364.31
698:191867295:PRES:cloud base:rpn_corr=0.91432:rpn_rms=15296.7
708:195473891:CDCON:convective cloud layer:rpn_corr=-nan:rpn_rms=undefined
[Wen.Meng@hfe07 ~/stmp2]$ cat rap_2020072316/WRFNAT.GrbF16.diff
1070:282595626:HGT:cloud base:rpn_corr=0.895998:rpn_rms=3364.31
1071:283749203:PRES:cloud base:rpn_corr=0.91432:rpn_rms=15296.7
[Wen.Meng@hfe07 ~/stmp2]$ cat hrrr_2020060118/WRFTWO.GrbF04.diff
121:85620587:HGT:cloud base:rpn_corr=0.932971:rpn_rms=2896.63
122:88068643:PRES:cloud base:rpn_corr=0.931465:rpn_rms=12453.8

I would assume these changes come from updates in CLDRAD.f?

Now I saw valid cloud fraction in GSL RRFS test at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_rrfs_2022102713. Would you please verify my testing? Thanks!

@WenMeng-NOAA yes, we changed the formulation of the exp2 ceiling diagnostic, which would affect these fields. We are seeking to improve the diagnostic for RRFS for the FAA. Your GSL RRFS test looks good to me! Thanks!

@WenMeng-NOAA WenMeng-NOAA linked an issue Jan 31, 2023 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. The updates of baselines for rap and hrrr are needed with this PR.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Would you add change logs in two source code files CLDRAD.f and INITPOST_NETCDF.f so I can proceed to merging?

@SamuelTrahanNOAA
Copy link
Contributor Author

Would you add change logs in two source code files CLDRAD.f and INITPOST_NETCDF.f so I can proceed to merging?

It is done.

@WenMeng-NOAA WenMeng-NOAA merged commit 7477b93 into NOAA-EMC:develop Jan 31, 2023
@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. RRFS labels Jan 31, 2023
@SamuelTrahanNOAA SamuelTrahanNOAA deleted the merge_RRFS_dev_to_develop branch January 31, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve remaining differences with GSL RRFS_dev UPP
5 participants