NEMSCompsetRun bug fix: pass --label to srun (requires produtil PR) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamuelTrahanNOAA , can you please update this PR to include the latest NEMS and NCEPLIBS-pyprodutil changes? Thanks! |
I merged the changes and I'm testing them now on Hera. |
|
@MinsukJi-NOAA The deed is done. I've merged the latest NEMS develop. I re-ran NEMSCompsetRun for the ufs-weather-model: all tests passed and the log file had the MPI rank at the beginning of each line. |
Thanks! Merged the PR. |
hyunchul386
pushed a commit
to hyunchul386/NEMS
that referenced
this pull request
Jul 24, 2020
increate netcdf file attribute length limit from 512 to 1280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NEMSCompsetRun was asking produtil to pass the
--labeloption, but that request was ignored since produtil.mpi_impl.srun_shell ignored thelabel_io=Trueoption. This NCEPLIBS-pyprodutil PR fixes the bug in produtil. The submodule at the NEMS level must be updated as well: