Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srun --label support: pass --label when label_io=True #5

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Mar 25, 2020

The srun.py and srun_shell.py were ignoring the label_io option. This corrects that bug: when label_io=True, it adds the --label option to the srun command.

This is needed for a bug fix to the NEMSCompsetRun, requested by dom.heinzeller@noaa.gov

This NEMS PR updates the produtil submodule to point to the hash of this produtil version:

@MinsukJi-NOAA
Copy link
Contributor

NEMSCompsetRun regression tests passed:

@RatkoVasic-NOAA RatkoVasic-NOAA merged commit ca171b9 into NOAA-EMC:develop Mar 30, 2020
@climbfuji
Copy link

Thanks, @RatkoVasic-NOAA. @MinsukJi-NOAA, please let me know when you plan to merge the associated NEMS PR. I will update both in the latest PR for the s2s model. Thanks!

@MinsukJi-NOAA
Copy link
Contributor

Thanks, @RatkoVasic-NOAA. @MinsukJi-NOAA, please let me know when you plan to merge the associated NEMS PR. I will update both in the latest PR for the s2s model. Thanks!

I will merge the NEMS PR this afternoon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants