Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing of the Marine DA jjobs #234

Merged
merged 16 commits into from
Dec 14, 2022
Merged

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Dec 7, 2022

Still a bit of a work todo but good enough for a draft PR.

Addition of 3 ctests related to running with the g-w

  • Copy/paste of @CoryMartin-NOAA 's setup_expt.py test adjusted to soca
  • jjob for the Marine DA prep step (create yaml's, stage obs and bkg's, ...)
  • jjob for the Marine DA run step (gridgen, static B init., run var, create iau increment, ...)

Stuff left to do

  • Only tested in a singularity container
    - As I type this I'm wondering if the changes I made to the g-w are needed (probably not)
  • The prep jjob fails when run twice in a row, simple fix but still in the todo list
  • ...

Issues addressed

Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments/questions

scripts/exgdas_global_marine_analysis_prep.py Show resolved Hide resolved
scripts/exgdas_global_marine_analysis_prep.py Show resolved Hide resolved
test/soca/gw/jjob_prep.sh Show resolved Hide resolved
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Dec 7, 2022
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 7, 2022
@emcbot
Copy link

emcbot commented Dec 7, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Dec  7 19:47:33 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec  7 20:43:53 UTC 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Dec  7 20:45:39 UTC 2022
Tests: 89% tests passed, 3 tests failed out of 28
	1291 - test_gdasapp_soca_ana_run (Failed)
	1293 - test_gdasapp_soca_jjob_soca_prep (Failed)
	1294 - test_gdasapp_soca_jjob_soca_run (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/234/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 7, 2022
@guillaumevernieres
Copy link
Contributor Author

Looks like I hard-coded CONTAINER in config.base, so the new tests are failing and ... the file name is 136 character long, so it's truncated when going through fms io. I'm not sure why that bug didn't show up the last time we ran the ci.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Dec 7, 2022
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 7, 2022
@emcbot
Copy link

emcbot commented Dec 7, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Dec  7 23:15:53 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec  7 23:57:29 UTC 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Dec  7 23:59:48 UTC 2022
Tests: 86% tests passed, 4 tests failed out of 28
	1290 - test_gdasapp_setup_cycled_exp (Failed)
	1301 - test_gdasapp_soca_ana_run (Failed)
	1303 - test_gdasapp_soca_jjob_soca_prep (Failed)
	1304 - test_gdasapp_soca_jjob_soca_run (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/234/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 7, 2022
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Dec 8, 2022
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Dec 8, 2022
@emcbot
Copy link

emcbot commented Dec 8, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Thu Dec  8 21:30:38 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Dec  8 21:54:02 UTC 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Dec  8 21:55:44 UTC 2022
Tests: 90% tests passed, 3 tests failed out of 29
	1290 - test_gdasapp_setup_cycled_exp (Failed)
	1304 - test_gdasapp_soca_jjob_soca_prep (Failed)
	1305 - test_gdasapp_soca_jjob_soca_run (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/234/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot removed the hera-GW-RT-Running Automated testing with global-workflow running on Hera label Dec 8, 2022
@emcbot
Copy link

emcbot commented Dec 14, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Dec 14 03:00:36 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec 14 03:24:51 UTC 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Wed Dec 14 03:28:05 UTC 2022
Tests: 97% tests passed, 1 tests failed out of 31
	1298 - test_gdasapp_setup_cycled_exp (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/234/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 14, 2022
@emcbot
Copy link

emcbot commented Dec 14, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Dec 13 21:00:54 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Dec 13 21:28:23 CST 2022
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Dec 13 21:34:32 CST 2022
Tests: 97% tests passed, 1 tests failed out of 31
	1298 - test_gdasapp_setup_cycled_exp (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/234/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Dec 14, 2022
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Dec 14, 2022
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Dec 14, 2022
@guillaumevernieres
Copy link
Contributor Author

We shall see, but I think all our test should be re-runable (it's a word ... ) now.

@emcbot
Copy link

emcbot commented Dec 14, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Dec 14 12:30:53 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec 14 12:55:08 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Dec 14 12:58:49 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 31

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Dec 14, 2022
@emcbot
Copy link

emcbot commented Dec 14, 2022

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Wed Dec 14 06:30:49 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Dec 14 06:59:12 CST 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Dec 14 07:04:49 CST 2022
Tests: 100% tests passed, 0 tests failed out of 31

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Dec 14, 2022
@guillaumevernieres
Copy link
Contributor Author

Re-requesting your review @CoryMartin-NOAA , I had to add a few changes to make some of the ctest "re-runable".

@guillaumevernieres guillaumevernieres merged commit 98a8294 into develop Dec 14, 2022
WalterKolczynski-NOAA pushed a commit to NOAA-EMC/global-workflow that referenced this pull request Jan 31, 2023
Adds the UFSDA location to PYTHONPATH in soca prep jjob so the path building is not done in script.

Refs: NOAA-EMC/GDASApp#242 and NOAA-EMC/GDASApp#234

The issues require changes also to GDASApp, but this PR will not break GDASApp as is
@guillaumevernieres guillaumevernieres deleted the feature/ctest_ocnice_3dvar branch March 8, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5deg Marine 3DVar ctest using j-job
3 participants