Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yamls for MIRS type sea-ice obs in cycling test #1257

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Yamls for MIRS type sea-ice obs in cycling test #1257

merged 10 commits into from
Sep 24, 2024

Conversation

apchoiCMD
Copy link
Collaborator

@apchoiCMD apchoiCMD commented Aug 20, 2024 •
edited
Loading

This PR is to add the yaml key for cycling test

  • Yaml keys for MIRS_NPP Ioda Converters
  • Generate gdas.t06z.icec_mirs.2021063006.nc4 for the cycling test

Result looks like below

GFSv17-3DVAR-C384mx025_gdasprepoceanobs_202106300600

@apchoiCMD apchoiCMD changed the title aml for MIRS_NPP icec obs in cycling Yaml for MIRS_NPP icec obs in cycling test Aug 20, 2024
JohnSteffen-NOAA
JohnSteffen-NOAA previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@JohnSteffen-NOAA JohnSteffen-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

guillaumevernieres
guillaumevernieres reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but was this tested @apchoiCMD ?

AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

guillaumevernieres
guillaumevernieres requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review @apchoiCMD , just a minor comment related to the obs list.

parm/soca/obs/obs_list.yaml Outdated Show resolved Hide resolved
guillaumevernieres
guillaumevernieres requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming convention you use is not correct, see comment.

parm/soca/obs/obs_list.yaml Outdated Show resolved Hide resolved
@apchoiCMD apchoiCMD changed the title Yaml for MIRS_NPP icec obs in cycling test Yamls for MIRS type sea-ice obs in cycling test Sep 12, 2024
AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right

guillaumevernieres
guillaumevernieres approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @apchoiCMD .

@guillaumevernieres guillaumevernieres merged commit 7523c48 into develop Sep 24, 2024
5 checks passed
@guillaumevernieres guillaumevernieres deleted the feature/icec_mirs_yaml branch September 24, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@JohnSteffen-NOAA JohnSteffen-NOAA JohnSteffen-NOAA approved these changes

@givelberg givelberg Awaiting requested review from givelberg

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apchoiCMD @guillaumevernieres @AndrewEichmann-NOAA @JohnSteffen-NOAA