Merge tag 'v0.7.2' #214
Merged
Merge tag 'v0.7.2' #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the trait bounds on FoundSrvs::into_stream which made it impossible to use. In addition, it adds a new method FoundSrvs::into_srvs that converts the value into an iterator over the found SRV records.
New * Added a new method `FoundSrvs::into_srvs` that converts the value into an iterator over the found SRV records without resolving them further. ([NLnetLabs#174]) Bug Fixes * Fix trait bounds on `FoundSrvs::into_stream` to make it usable again. ([NLnetLabs#174])
v0.7.2 contained fixed that were never ported to the main branch, and lost in the v0.8.0 release. Merge this branch to introduce both the changes themselves and retain their history. Fixes: NLnetLabs#213
|
I've resolved all conflicts in this branch and only retained the bits that were actually lost. Hence the relatively short diff. |
|
Thanks for the PR! I could have sworn I also added this to main. My apologies! |
miseenplace
pushed a commit
to miseenplace/vdirsyncer-rs
that referenced
this pull request
Jul 9, 2023
|
Do you mind publishing a v0.8.1 tag with this change? The fixes in e81ce58 are also missing from v0.8.0 but present in v0.7.2. |
|
Will do! I’ll merge the remaining open PRs and then make a release. |
|
Thanks! |
partim
added a commit
that referenced
this pull request
Sep 18, 2023
New * Added a new method `FoundSrvs::into_srvs` that converts the value into an iterator over the found SRV records without resolving them further. ([#174], [#214] by [@WhyNotHugo]); this was added in 0.7.2 but missing in 0.8.0) * Added impl of `Borrow<Dname<[u8]>>` and `AsRef<Dname<[u8]>>` for `Dname<_>`. ([#219] by [@iximeow}], [#225]) * Added `Dname::fmt_with_dot` that can be used when wanting to display a domain name with a dot at the end. ([#210]) Bug Fixes * Fixed trait bounds on `FoundSrvs::into_stream` to make it usable again. ([#174], [#214 by [@WhyNotHugo]]; this was fixed in 0.7.2 but missing in 0.8.0) * Fixed scanning of domain names that are just the root label. ([#210]) * Fixed `util::base64::SymbolConverter` to also include the final group in the output if there is padding. ([#212])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.7.2 contained fixed that were never ported to the main branch, and
lost in the v0.8.0 release.
Merge this branch to introduce both the changes themselves and retain
their history.
Fixes: #213