Fix the Base 64 symbol converter. #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/utils/base64.rs
Outdated
| if self.input[2] == 0x80 { | ||
| return Err(Error::custom("trailing Base 64 data")); | ||
|
|
||
| if self.input[2] == 0x80 { |
There was a problem hiding this comment.
It would be nice if this could be a constant.
src/utils/base64.rs
Outdated
| // The second to last character is padding. The last one | ||
| // needs to be, too. | ||
| if self.input[3] == 0x80 { | ||
| self.next = 0xF0; |
Philip-NLnetLabs
approved these changes
Jul 18, 2023
partim
added a commit
that referenced
this pull request
Sep 18, 2023
New * Added a new method `FoundSrvs::into_srvs` that converts the value into an iterator over the found SRV records without resolving them further. ([#174], [#214] by [@WhyNotHugo]); this was added in 0.7.2 but missing in 0.8.0) * Added impl of `Borrow<Dname<[u8]>>` and `AsRef<Dname<[u8]>>` for `Dname<_>`. ([#219] by [@iximeow}], [#225]) * Added `Dname::fmt_with_dot` that can be used when wanting to display a domain name with a dot at the end. ([#210]) Bug Fixes * Fixed trait bounds on `FoundSrvs::into_stream` to make it usable again. ([#174], [#214 by [@WhyNotHugo]]; this was fixed in 0.7.2 but missing in 0.8.0) * Fixed scanning of domain names that are just the root label. ([#210]) * Fixed `util::base64::SymbolConverter` to also include the final group in the output if there is padding. ([#212])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
util::base64::SymbolConverterto also include the final group in the output if there is padding.