feat(net): support evento v1 api #182
Serein207Annotations
2 errors and 9 warnings
|
review
'slint_internal.h' file not found [clang-diagnostic-error]
|
|
review:
src/Controller/Convert.h#L4
'app.h' file not found [clang-diagnostic-error]
|
|
review:
src/Controller/Core/AccountManager.cc#L238
method 'getKeychainAccessToken' can be made static [readability-convert-member-functions-to-static]
|
|
review:
src/Controller/Core/AccountManager.cc#L255
method 'setKeychainAccessToken' can be made static [readability-convert-member-functions-to-static]
|
|
review:
src/Controller/Core/AccountManager.h#L54
function 'getKeychainAccessToken' should be marked [[nodiscard]] [modernize-use-nodiscard]
|
|
review:
src/Infrastructure/Network/NetworkClient.cc#L57
Value stored to 'state' is never read [clang-analyzer-deadcode.DeadStores]
|
|
review:
src/Infrastructure/Network/NetworkClient.cc#L59
Value stored to 'state' is never read [clang-analyzer-deadcode.DeadStores]
|
|
review:
src/Infrastructure/Network/NetworkClient.cc#L61
Value stored to 'state' is never read [clang-analyzer-deadcode.DeadStores]
|
|
review:
src/Infrastructure/Network/NetworkClient.cc#L81
'listV2' used after it was moved [bugprone-use-after-move]
|
|
review:
src/Infrastructure/Network/NetworkClient.cc#L81
Method called on moved-from object 'listV2' of type 'std::vector' [clang-analyzer-cplusplus.Move]
|
|
review:
src/Infrastructure/Network/Response/SlideEntityV1.h#L10
constructor does not initialize these fields: id [cppcoreguidelines-pro-type-member-init]
|