Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): support evento v1 api #68

Merged
merged 11 commits into from
Sep 30, 2024
Merged

feat(net): support evento v1 api #68

merged 11 commits into from
Sep 30, 2024

Conversation

Serein207
Copy link
Member

No description provided.

@Serein207 Serein207 added the feature New feature or request label Sep 29, 2024
@Serein207 Serein207 linked an issue Sep 29, 2024 that may be closed by this pull request
@Serein207 Serein207 changed the title feat: support evento v1 api feat(net): support evento v1 api Sep 29, 2024
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
@Serein207 Serein207 force-pushed the feat/net/v1-api-support branch from 1bd395c to df0cffd Compare September 29, 2024 17:21
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.h Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.h Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.h Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Outdated Show resolved Hide resolved
@Serein207 Serein207 marked this pull request as ready for review September 29, 2024 19:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Controller/Core/AccountManager.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
src/Infrastructure/Network/NetworkClient.cc Show resolved Hide resolved
@Serein207 Serein207 merged commit 2325031 into dev Sep 30, 2024
5 checks passed
@Serein207 Serein207 deleted the feat/net/v1-api-support branch September 30, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support evento v1 api
2 participants