Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:slider): support nzTooltipVisible #2930

Merged
merged 3 commits into from
Feb 21, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 19, 2019

close #2373

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase
@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6809830

https://deploy-preview-2930--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #2930 into master will increase coverage by 0.02%.
The diff coverage is 93.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2930      +/-   ##
==========================================
+ Coverage   97.36%   97.39%   +0.02%     
==========================================
  Files         524      525       +1     
  Lines       11042    11011      -31     
  Branches      782      788       +6     
==========================================
- Hits        10751    10724      -27     
+ Misses        190      185       -5     
- Partials      101      102       +1
Impacted Files Coverage Δ
components/core/util/getMentions.ts 60% <ø> (ø) ⬆️
components/slider/nz-slider.module.ts 100% <ø> (ø) ⬆️
components/core/util/check.ts 91.17% <ø> (ø) ⬆️
components/slider/nz-slider-track.component.ts 100% <100%> (ø) ⬆️
components/timeline/nz-timeline.component.ts 97.87% <100%> (ø) ⬆️
components/core/util/number.ts 100% <100%> (ø)
components/cascader/nz-cascader.component.ts 99.22% <100%> (ø) ⬆️
components/core/util/array.ts 100% <100%> (ø) ⬆️
components/slider/nz-slider-definitions.ts 100% <100%> (ø)
components/slider/nz-slider-handle.component.ts 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2fde8c...6809830. Read the comment docs.

Wendell added 2 commits February 20, 2019 16:27
fix setting to always wouldn't take effect
@vthinkxie
Copy link
Member

缺少拖拽时的border样式

@vthinkxie vthinkxie merged commit d3e61d4 into NG-ZORRO:master Feb 21, 2019
@wzhudev wzhudev deleted the slider branch February 22, 2019 02:29
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:slider): support nzTooltipVisible

close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase

* fix: remove redundant class

fix setting to always wouldn't take effect

* fix: fix test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:slider): support nzTooltipVisible

close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase

* fix: remove redundant class

fix setting to always wouldn't take effect

* fix: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slider: minimum value should always of zero position in range mode
3 participants