Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slider: minimum value should always of zero position in range mode #2373

Closed
cipchk opened this issue Oct 29, 2018 · 2 comments · Fixed by #2930
Closed

slider: minimum value should always of zero position in range mode #2373

cipchk opened this issue Oct 29, 2018 · 2 comments · Fixed by #2930
Assignees
@wzhudev
Labels
🐛 Bug Component: Slider

Comments

@cipchk
Copy link
Member

cipchk commented Oct 29, 2018

重现

Angular

https://stackblitz.com/edit/angular-n2vcdt?file=src/app/app.component.ts

gif:

ng

React

https://codepen.io/cipchk/pen/wYZazP?editors=0010

gif:

react
@cipchk cipchk changed the title slider：双滑块模式时最小值应始终在第一位 slider: minimum value should always of zero position in range mode Oct 29, 2018
@wzhudev wzhudev self-assigned this Oct 29, 2018
@wzhudev
Copy link
Member

wzhudev commented Dec 27, 2018

@wilsoncook I noticed that you would refactor this component so I would reassign this issue to you.

@wzhudev wzhudev removed their assignment Dec 27, 2018
@wzhudev
Copy link
Member

wzhudev commented Jan 4, 2019

Ref #1547.

@wzhudev wzhudev assigned wzhudev and unassigned wilsoncook Jan 4, 2019
@wzhudev wzhudev mentioned this issue Jan 18, 2019
Closed
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jan 21, 2019
feat(module:slider): support nzTooltipVisible
8155fcd 
close NG-ZORRO#2373
@wzhudev wzhudev mentioned this issue Jan 21, 2019
Closed
3 tasks
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Jan 21, 2019
feat(module:slider): support nzTooltipVisible
aa6b428 
close NG-ZORRO#2373
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 12, 2019
feat(module:slider): support nzTooltipVisible
e0a9043 
close NG-ZORRO#2373
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 16, 2019
feat(module:slider): support nzTooltipVisible
f002f24 
close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 19, 2019
feat(module:slider): support nzTooltipVisible
81aab73 
close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase
wzhudev pushed a commit to wzhudev/ng-zorro-antd that referenced this issue Feb 19, 2019
feat(module:slider): support nzTooltipVisible
400d2ac 
close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase
@wzhudev wzhudev mentioned this issue Feb 19, 2019
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Feb 21, 2019
@vthinkxie
feat(module:slider): support nzTooltipVisible (#2930)
d3e61d4 
* feat(module:slider): support nzTooltipVisible

close #2373

test: add test

fix: fix hover handles

rebase

* fix: remove redundant class

fix setting to always wouldn't take effect

* fix: fix test
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet
feat(module:slider): support nzTooltipVisible (NG-ZORRO#2930)
bbcae9b 
* feat(module:slider): support nzTooltipVisible

close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase

* fix: remove redundant class

fix setting to always wouldn't take effect

* fix: fix test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@vthinkxie
feat(module:slider): support nzTooltipVisible (NG-ZORRO#2930)
b35b002 
* feat(module:slider): support nzTooltipVisible

close NG-ZORRO#2373

test: add test

fix: fix hover handles

rebase

* fix: remove redundant class

fix setting to always wouldn't take effect

* fix: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

Labels
🐛 Bug Component: Slider
Projects
None yet
Milestone
No milestone
4 participants
@vthinkxie @wilsoncook @cipchk @wzhudev