Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/history limit #3

Merged
merged 4 commits into from
Mar 14, 2018
Merged

Feature/history limit #3

merged 4 commits into from
Mar 14, 2018

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Mar 13, 2018

The default is no limit. Should we force a limit if none is set?

@nilmerg nilmerg requested a review from dnsmichi March 13, 2018 14:55
@dnsmichi
Copy link
Contributor

dnsmichi commented Mar 13, 2018 •
edited
Loading

  • no limit set

screen shot 2018-03-13 at 16 11 21

The text in there might need a change?

  • 2 < 5
Set($RT_Extension_UpdateHistory_MaxEntries, 2);

screen shot 2018-03-13 at 16 13 30

@nilmerg nilmerg force-pushed the feature/history-limit branch from 1d17482 to e486e13 Compare March 14, 2018 07:19
@nilmerg
Copy link
Member Author

nilmerg commented Mar 14, 2018

Erm. Fixed. :)

dnsmichi
dnsmichi approved these changes Mar 14, 2018
View reviewed changes
Copy link
Contributor

@dnsmichi dnsmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you 😍

@nilmerg nilmerg merged commit 6993cb5 into master Mar 14, 2018
@nilmerg nilmerg deleted the feature/history-limit branch March 14, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsmichi dnsmichi dnsmichi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilmerg @dnsmichi