Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp compose #149

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Revamp compose #149

merged 4 commits into from
Feb 14, 2024

Conversation

itexpert120
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ❌ Failed (Inspect) Feb 13, 2024 11:20pm

@elliotBraem
Copy link
Contributor

elliotBraem commented Feb 14, 2024

Wow, this looks amazing.

Linked to issue: #147

I think this could be integrated with the Feed object, so I've merged over devs.near/widget/Feed into the apps directory. Notice the showCompose: devs.near/widget/Feed.

I don't remember what devs.near/widget/Compose looks like, but what if generic version lives there and the version that defines the Post, Compose, theme, index, etc is the buildhub.near/widget/Compose?

Acceptance Criteria

  • Fast as before (whole feed seems to take longer to load)
  • Draft persists on reload
  • appends required hashtags when posting
  • preloads the post template
  • can attach image
  • can preview
  • can add GIF?
  • account id autocomplete w/ apply on click

@elliotBraem elliotBraem merged commit fcb2df5 into main Feb 14, 2024
1 of 2 checks passed
@@ -457,7 +457,7 @@ return (
embedCss: props.customCSS || MarkdownEditor,
Copy link
Contributor

@elliotBraem elliotBraem Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itexpert120 re: account autocomplete

buildhub.near/widget/components.MarkdownEditorIframe and the handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants