Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Compose #147

Closed
elliotBraem opened this issue Feb 13, 2024 · 3 comments
Closed

Clean up Compose #147

elliotBraem opened this issue Feb 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@elliotBraem
Copy link
Contributor

Our current Compose is just one large file and is prone to breakage.

We should utilize the patterns from mob.enar/widget/MainPage.N.Compose and mob.near/widget/MainPage.N.Compose.Common. Notice how this Common "wrapper" is able to take in a custom markdown editor from props, and then passes these functionalities to it.

For context, the goal is that we can use these features in whatever editor we plan to swap it out for. The implementation should be style agnostic.

Bonus: we can also adopt the advanced vs plain textbox editor pattern in common compose as well.

@elliotBraem elliotBraem added enhancement New feature or request help wanted Extra attention is needed labels Feb 13, 2024
@elliotBraem elliotBraem added this to the maintenance milestone Feb 13, 2024
@itexpert120 itexpert120 self-assigned this Feb 13, 2024
@elliotBraem
Copy link
Contributor Author

@itexpert120 it looks like we did lose account id autocomplete w/ apply on click. What I mean by this, is that when you do auto complete and click the account it should autocomplete the text in the compose. Right now if you click it, nothing happens.

Also, we should make sure that the compose clears after posting (post with #test); there was a Toast that had been put in last week, now removed

@itexpert120
Copy link
Collaborator

I think the autocomplete can be attributed to iframe issue. And I'll implement rest of these features too.

@itexpert120
Copy link
Collaborator

Fixed, please check new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

2 participants