Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send email notifications for pending assessments #3286

Merged
merged 10 commits into from
Nov 18, 2020
Merged

Send email notifications for pending assessments #3286

merged 10 commits into from
Nov 18, 2020

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Nov 9, 2020 •
edited
Loading

Users will get an email for any pending assessments they may have (for their counterparts and/or the task for which they are responsible).

Release notes

Closes #3231

User changes

  • Users will get a notification email for any pending recurring assessments they may have after a recurrence period ends (for their counterparts and/or the task for which they are responsible). And if after a while the assessment still hasn't been created, they will get a reminder email.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • none
  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2020

This pull request introduces 6 alerts when merging 3d72e68 into 787c651 - view on LGTM.com

new alerts:

  • 2 for Result of multiplication cast to wider type
  • 2 for Useless parameter
  • 2 for Inner class could be static

@gjvoosten gjvoosten force-pushed the GH-3231-pending-assessments-email-notification branch 7 times, most recently from 50d79bf to 04ffd2e Compare November 16, 2020 13:32
@gjvoosten gjvoosten force-pushed the GH-3231-pending-assessments-email-notification branch 4 times, most recently from 8bb54cf to 3fd0c88 Compare November 18, 2020 14:16
@gjvoosten
#3231: Pull up logger, and always pass AnetConfiguration to constructor
8c0800f 
Move worker creation closer to where it's scheduled.
Make some variables final.
@gjvoosten
#3231: Prevent NPE when getting a non-existing key path
05a3eb5
@gjvoosten
#3231: Enhance method to get either all active top- or sub-level tasks
e05fc69
@gjvoosten
#3231: Add method to safely parse JSON
246ebe6
@gjvoosten
#3268: Defer getting entries from the dictionary
d7550aa 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
@gjvoosten
Extract common code to create Freemarker config
dbf4874
@gjvoosten
#3231: Move metricRegistry to AnetObjectEngine
a105402
@gjvoosten
#3231: Introduce a batching & caching context for workers
b3cd57e
@gjvoosten
#3231: Make relevant parts of some workers asynchronous
1f98e76 
This gives the context the opportunity to batch queries.
@gjvoosten
#3231: Add PendingAssessmentsNotificationWorker
49f3983
@gjvoosten gjvoosten force-pushed the GH-3231-pending-assessments-email-notification branch from 3fd0c88 to 49f3983 Compare November 18, 2020 14:24
@gjvoosten gjvoosten marked this pull request as ready for review November 18, 2020 14:47
@VassilIordanov VassilIordanov merged commit 8b61b70 into candidate Nov 18, 2020
@VassilIordanov VassilIordanov deleted the GH-3231-pending-assessments-email-notification branch November 18, 2020 15:49
@gjvoosten gjvoosten mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VassilIordanov VassilIordanov VassilIordanov approved these changes

@maradragan maradragan Awaiting requested review from maradragan

@cemalettin-work cemalettin-work Awaiting requested review from cemalettin-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pending assessments email notification
2 participants
@gjvoosten @VassilIordanov