Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all changes in the dictionary are reflected everywhere after reloading #3268

Closed
gjvoosten opened this issue Oct 27, 2020 · 1 comment
Closed

Make sure all changes in the dictionary are reflected everywhere after reloading #3268

gjvoosten opened this issue Oct 27, 2020 · 1 comment
Assignees
@gjvoosten
Labels
debt

Comments

@gjvoosten
Copy link
Collaborator

Technical debt description
Not all changes in the dictionary are reflected throughout the application after reloading. E.g. AccountDeactivationWorker and ReportResource (and others) get some things from the dictionary in the constructor (only called at application start-up), or even before that like in AnetApplication::runAccountDeactivationWorker.

Proposed solution
Get dictionary entries where they are needed (as late as possible/practical).

Additional context
none
@gjvoosten gjvoosten added the debt label Oct 27, 2020
@gjvoosten gjvoosten self-assigned this Oct 27, 2020
gjvoosten added a commit that referenced this issue Oct 29, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
2c5bfa9 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 4, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
dab10ec 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 5, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
c4811da 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 9, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
475609e 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 10, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
5886307 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 11, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
6f580b5 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 12, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
1ee5915 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 12, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
616af93 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 16, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
55d7751 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 16, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
56333cc 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 17, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
645dda4 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 18, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
940a92d 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 18, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
a8442f5 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
gjvoosten added a commit that referenced this issue Nov 18, 2020
@gjvoosten
#3268: Defer getting entries from the dictionary
d7550aa 
With the exception of the AccountDeactivationWorker schedule, changes in the dictionary are now properly reflected after a reload.
@gjvoosten
Copy link
Collaborator Author

Closed by commit d7550aa as part of #3286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjvoosten gjvoosten

Labels
debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gjvoosten