Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs_public_release: bugfix for reading Thompson lookup tables in a threaded environment #387

Conversation

DomHeinzeller
Copy link
Contributor

@DomHeinzeller DomHeinzeller commented Jan 24, 2020

  • physics/module_mp_thompson.F90: bugfix, remove threaded computation/reading of lookup tables, because the Fortran unit used to read them is the same (63)

This was tested to fix an error that was found by several people simultaneously using the global workflow (which uses multiple threads).

Associated PRs:
ufs-community/ufs-weather-model#35
NOAA-EMC/fv3atm#47
NCAR/ccpp-framework#255
#387
NOAA-EMC/GFDL_atmos_cubed_sphere#12

@climbfuji climbfuji merged commit 90c9516 into NCAR:ufs_public_release Jan 24, 2020
@climbfuji climbfuji deleted the ufs_public_release_thompson_threading_fix branch June 27, 2022 03:26
hannahcbarnes pushed a commit to hannahcbarnes/ccpp-physics that referenced this pull request Aug 3, 2022
* modification to add extra land fields to the output
* Update GFS_diagnostics.F90,
* make those three extra land outputs as Noah MP only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants