ufs_public_release: bugfix for converting optional attribute from new metadata for ccpp_prebuild.py, correct log message for automated unit conversions #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated unit conversions in ccpp_prebuild.py
…from new to old metadata
This was referenced Jan 24, 2020
DomHeinzeller
requested review from
climbfuji,
grantfirl and
llpcarson
as code owners
grantfirl
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/metadata_parser.py: bugfix for converting optional attribute from new to old metadatascripts/mkcap.py: change the log message to match the logic for automated unit conversions inccpp_prebuild.pyAssociated PRs:
ufs-community/ufs-weather-model#35
NOAA-EMC/fv3atm#47
#255
NCAR/ccpp-physics#387
NOAA-EMC/GFDL_atmos_cubed_sphere#12