dtc/develop: prevent mismatch of namelist and suite definition file settings for ozone physics #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han hard-coded input.nml
…h of namelist option for old/new ozphys and entry in suite definition file
climbfuji
requested review from
grantfirl,
JulieSchramm and
llpcarson
as code owners
…l/ccpp-physics into ozphys_guard_based_on_dtc_develop
This was referenced Nov 5, 2019
Closed
Merged
|
ufs-weather-model regression test using dtc/develop branches and this PR all pass: |
grantfirl
approved these changes
Nov 7, 2019
bluefinweiwei
pushed a commit
to bluefinweiwei/ccpp-physics
that referenced
this pull request
Nov 13, 2019
…develop dtc/develop: prevent mismatch of namelist and suite definition file settings for ozone physics modified: cires_ugwp.F90 modified: cires_ugwp_triggers.F90 modified: docs/ccpp_doxyfile modified: docs/library.bib new file: docs/pdftxt/UGWPv0.txt modified: docs/pdftxt/all_shemes_list.txt modified: ugwp_driver_v0.F
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…ve snet from noah lsm, fix time dimension in restart files (NCAR#350) - Update of submodule pointers for ccpp-physics for the changes listed below - Thompson inner loop from @RuiyuSun - Thompson subcycling bugfix from @climbfuji - Noah/NoahMP bugfix/remove snet from Noah LSM from @HelinWei-NOAA - Fix time dimension in restart files from @climbfuji Co-authored-by: Helin Wei <Helin.Wei@noaa.gov> Co-authored-by: Ruiyu Sun <Ruiyu.Sun@noaa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: target dtc/develop
This PR adds guards to the init routines of the old and new ozone physics that prevent mismatches of the namelist options oz_phys/oz_phys_2015 and the entry in the suite definition file.
This PR includes the CIRES UGWP namelist fix from @grantfirl (#343).
Associated PRs:
NCAR/ccpp-scm#136
MISSING PR for ufs-weather-model