Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1 templates #2

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Feature 1 templates #2

merged 1 commit into from
Feb 23, 2024

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Feb 23, 2024

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    I have not performed any testing of these changes. No testing is required.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review the new files. In case you're unfamiliar with how to review the files, on this page there is a "Files Changed" tab that you can click on to see the files that changed. Don't pay too much attention to the "Bugfix Checklist" and "New Feature Checklist" sections of the bug.md and new_feature.md file as I plan to talk about a plan for those with you two at a later date. It would be good to just get these in there for future issues.

Please offer any suggestions for changes and ask any questions you may have.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [N/A]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [No required date, whenever you get to it].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop linked an issue Feb 23, 2024 that may be closed by this pull request
4 tasks
@jprestop
Copy link
Collaborator Author

@jsauer-NCAR Thanks for the approval! @domingom, since Jeremy approved, I'm going to go ahead and merge this in now. Please speak up if you'd like to see any changes and I can make those and start a new PR.

@jprestop jprestop removed the request for review from domingom February 23, 2024 21:43
@jprestop jprestop merged commit 1b9a9bb into main Feb 23, 2024
jprestop added a commit that referenced this pull request Feb 23, 2024
jprestop added a commit that referenced this pull request Feb 23, 2024
@jprestop jprestop deleted the feature_1_templates branch March 25, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add templates for Issues and Pull Requests
2 participants