Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 3 rtd doc #2 #5

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feature 3 rtd doc #2 #5

merged 1 commit into from
Feb 23, 2024

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

No testing yet. Adding in these continuous integration files:

  • .github/jobs/build_documentation.sh
  • .github/workflows/documentation.yml

should allow me to test future pushes to my feature branch.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Bypassing reviewers in order to get these into main. I will send this information to @jsauer-NCAR and @domingom afterward so that they can talk a look at what was added.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [N/A]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Merging myself as described above].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • [N/A] Select: Reviewer(s)
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop merged commit 4f73e48 into main Feb 23, 2024
2 checks passed
@jprestop jprestop linked an issue Feb 23, 2024 that may be closed by this pull request
4 tasks
jprestop added a commit that referenced this pull request Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up the FastEddy Tutorial documentation
1 participant