Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WRF hybrid vertical coordinate #650

Merged
merged 23 commits into from
Apr 23, 2024
Merged

Add WRF hybrid vertical coordinate #650

merged 23 commits into from
Apr 23, 2024

Conversation

braczka
Copy link
Contributor

@braczka braczka commented Mar 4, 2024

Description:

Adds the ability for DART to detect whether WRF is using Hybrid Vertical Coordinate (HVC) or terrain following (TF) system. WRF added this capability starting in WRFv3.9. The DART code automatically identifies the coordinate system by identifying coordinate attribute information within WRF file. Also compatible with pre WRFv3.9 versions which did not include explicit attribute information for vertical coordinate system.

Fixes issue

Fixes issue #649

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

nancycollins and others added 4 commits January 26, 2024 10:51
test for the hybrid coordinate attribute, and if set, compute the
vertical with the hybrid coordinate equation.  this requires 2 additional
arrays to be read, and written to the output files.

this fix was originally contributed by anders jensen in 2019.
@braczka braczka added the wrf Weather Research & Forecasting Model label Mar 4, 2024
@braczka braczka requested a review from hkershaw-brown March 4, 2024 21:38
@braczka braczka self-assigned this Mar 4, 2024
@hkershaw-brown
Copy link
Member

@braczka is this pull request ready for review?

@braczka
Copy link
Contributor Author

braczka commented Apr 5, 2024

@braczka is this pull request ready for review?

Not quite yet. I haven't heard anything from Arthur about any testing that his group has done. I have had success testing the sigma hybrid code as part of my comment to the WRF refactor issue here: #404 (comment). Things look good (the code worked with WRFv4.0), but I need to do some additional testing with different versions of WRFv3 and 4 that isolate the impact of sigma hybrid coordinate code. I should have this done in less than a week -- Derecho has been down the last couple of days, so I switched off to different tasks.

@hkershaw-brown hkershaw-brown mentioned this pull request Apr 5, 2024
@braczka
Copy link
Contributor Author

braczka commented Apr 16, 2024

I tested this sigma hybrid code with the WRF-DART Tutorial example for WRFv4.0 and WRFv4.5.2. I performed a third simulation with WRFv4.5.2, but with no sigma hybrid fix. All three cases can be found here:
/glade/derecho/scratch/bmraczka/WRF_DART_Tutorial
/glade/derecho/scratch/bmraczka/WRFv4.5_DART_Tutorial
/glade/derecho/scratch/bmraczka/WRFv4.5_DART_nohybrid

When including the sigma hybrid code the performance of WRFv4.5.2 appears very similar to WRFv3.9.1, based on standard tutorial statistics. For example WRF3.9.1 (left) and WRFv4.5.2 (right)

Screen Shot 2024-04-16 at 5 34 59 PM

Also of note is that if WRFv4.5.2 is run without the hybrid fix, the assimilation doesn't fail outright -- the performance is just deprecated as shown below (WRFv4.5.2 w/o hybrid fix on left, WRFv4.5.2 with hybrid fix on right)

Screen Shot 2024-04-16 at 5 39 35 PM

This means a WRFv4+ DART user could easily perform an assimilation without the hybrid fix and not realize the performance is deprecated. In terms of the fix itself, however, it looks good to go.

@braczka braczka marked this pull request as ready for review April 16, 2024 23:46
Copy link
Member

@hkershaw-brown hkershaw-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Apr 22, 2024
hkershaw-brown and others added 4 commits April 22, 2024 16:17
@hkershaw-brown hkershaw-brown merged commit 4b18402 into main Apr 23, 2024
4 checks passed
@hkershaw-brown hkershaw-brown deleted the WRF_vert_hybrid branch April 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release wrf Weather Research & Forecasting Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants