-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WRF hybrid vertical coordinate #650
Conversation
test for the hybrid coordinate attribute, and if set, compute the vertical with the hybrid coordinate equation. this requires 2 additional arrays to be read, and written to the output files. this fix was originally contributed by anders jensen in 2019.
Co-authored-by: nancy collins <nancy@ucar.edu>
@braczka is this pull request ready for review? |
Not quite yet. I haven't heard anything from Arthur about any testing that his group has done. I have had success testing the sigma hybrid code as part of my comment to the WRF refactor issue here: #404 (comment). Things look good (the code worked with WRFv4.0), but I need to do some additional testing with different versions of WRFv3 and 4 that isolate the impact of sigma hybrid coordinate code. I should have this done in less than a week -- Derecho has been down the last couple of days, so I switched off to different tasks. |
I tested this sigma hybrid code with the WRF-DART Tutorial example for WRFv4.0 and WRFv4.5.2. I performed a third simulation with WRFv4.5.2, but with no sigma hybrid fix. All three cases can be found here: When including the sigma hybrid code the performance of WRFv4.5.2 appears very similar to WRFv3.9.1, based on standard tutorial statistics. For example WRF3.9.1 (left) and WRFv4.5.2 (right) Also of note is that if WRFv4.5.2 is run without the hybrid fix, the assimilation doesn't fail outright -- the performance is just deprecated as shown below (WRFv4.5.2 w/o hybrid fix on left, WRFv4.5.2 with hybrid fix on right) This means a WRFv4+ DART user could easily perform an assimilation without the hybrid fix and not realize the performance is deprecated. In terms of the fix itself, however, it looks good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
adressing comment #663 (comment)
following google documentation style guide(ish)
citation change NCAR to NSF NCAR
obs_impact_tool documentation improvements
Fixed formatting on v11.4.0 changelog
Description:
Adds the ability for DART to detect whether WRF is using Hybrid Vertical Coordinate (HVC) or terrain following (TF) system. WRF added this capability starting in WRFv3.9. The DART code automatically identifies the coordinate system by identifying coordinate attribute information within WRF file. Also compatible with pre WRFv3.9 versions which did not include explicit attribute information for vertical coordinate system.
Fixes issue
Fixes issue #649
Types of changes
Documentation changes needed?
Checklist for merging
Checklist for release
Testing Datasets