Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citation change NCAR to NSF NCAR #663

Merged
merged 2 commits into from
Apr 23, 2024
Merged

citation change NCAR to NSF NCAR #663

merged 2 commits into from
Apr 23, 2024

Conversation

hkershaw-brown
Copy link
Member

Description:

A couple of "citing dart" info where NCAR needs changing to NSF NCAR

Fixes issue

#584

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Citation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Todo:

  • Check the citation file works
  • check readme.md looks ok.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Apr 22, 2024
@ann-norcio
Copy link
Contributor

Changes look good. Looks like there is a section in index.rst still referencing UCAR/NCAR/CISL/DAReS. Perhaps we can update this too, or remove it since we now have citation.cff?

Citing DART

Cite DART using the following text:

The Data Assimilation Research Testbed (Version X.Y.Z) [Software]. (2019).
Boulder, Colorado: UCAR/NCAR/CISL/DAReS. http://doi.org/10.5065/D6WQ0202

Update the DART version and year as appropriate.

@hkershaw-brown
Copy link
Member Author

Changes look good. Looks like there is a section in index.rst still referencing UCAR/NCAR/CISL/DAReS. Perhaps we can update this too, or remove it since we now have citation.cff?

Citing DART

Cite DART using the following text:

The Data Assimilation Research Testbed (Version X.Y.Z) [Software]. (2019). Boulder, Colorado: UCAR/NCAR/CISL/DAReS. http://doi.org/10.5065/D6WQ0202

Update the DART version and year as appropriate.

nice catch

@hkershaw-brown hkershaw-brown changed the base branch from main to WRF_vert_hybrid April 23, 2024 13:25
@hkershaw-brown hkershaw-brown merged commit 69ca8f6 into WRF_vert_hybrid Apr 23, 2024
4 checks passed
@hkershaw-brown
Copy link
Member Author

also README.md. 🙃 We'll change that in the next release.

@hkershaw-brown hkershaw-brown deleted the nsf_ncar branch April 23, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants