Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for deleting absence entries on table #637

Merged
merged 26 commits into from
Sep 12, 2022
Merged

Add support for deleting absence entries on table #637

merged 26 commits into from
Sep 12, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #598

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Added table to visualise and delete absence entry ranges
  • Added support for bulk deletion of absence ranges
  • Visualize ranges on timeline

Screenshot of the fix

bild

Testing

  • Visit /absence
  • Test reporting and deleting absence

@jonandernovella jonandernovella requested a review from a team September 8, 2022 08:32
HenrikeW
HenrikeW reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@HenrikeW HenrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments merely from looking through the code. Haven't been able to test it, /absence only shows the loader. Any hint on what might cause that?

frontend/src/index.css Outdated Show resolved Hide resolved
frontend/src/index.css Outdated Show resolved Hide resolved
frontend/src/pages/AbsencePlanner.tsx Outdated Show resolved Hide resolved
frontend/src/pages/AbsencePlanner.tsx Outdated Show resolved Hide resolved
frontend/src/index.css Outdated Show resolved Hide resolved
HenrikeW
HenrikeW approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@HenrikeW HenrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works & looks good to me now! 💯

@HenrikeW HenrikeW merged commit dc1451f into develop Sep 12, 2022
@HenrikeW HenrikeW deleted the feature/add-vacation-table branch September 12, 2022 13:03
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikeW HenrikeW HenrikeW approved these changes

Assignees

@jonandernovella jonandernovella

@KattisLej KattisLej

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete a planned vacation period
3 participants
@jonandernovella @HenrikeW @KattisLej