Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make application.properties.aws file agree w/ application.properties #221

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jimmie
Copy link
Contributor

@jimmie jimmie commented Dec 23, 2022

🗒️ Summary

Need to establish parity between application.properties.aws and application.properties by updating the former to reflect recent changes/additions in the latter. Some differences need to remain (e.g. openSearch host, username, password remain empty to invoke reading from environment, port number remains at 80)

…cation.properties to reflect recent additions/changes.
@jimmie
Copy link
Contributor Author

jimmie commented Dec 23, 2022

As noted in the original issue:

Note that this file (along with the registry-api jar file) is read in at the time the docker image is built so a new build of the registry-api artifacts is not necessary to support these changes.

@jordanpadams
Copy link
Member

@jimmie just to verify, the following is then being captured elsewhere right now?

server.contextPath=/
server.port=80
server.use-forward-headers=true

@jordanpadams
Copy link
Member

@jimmie ☝️

@jimmie
Copy link
Contributor Author

jimmie commented Jan 5, 2023

@jimmie just to verify, the following is then being captured elsewhere right now?

server.contextPath=/
server.port=80
server.use-forward-headers=true

They are still there, just shifted up to be in the same location as the other properties file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants