Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish parity between application.properties and application.properties.aws files #220

Closed
jimmie opened this issue Dec 23, 2022 · 3 comments

Comments

@jimmie
Copy link
Contributor

jimmie commented Dec 23, 2022

💡 Description

Certain configuration parameters (e.g. server.forward-headers-strategy, filter.archiveStatus, etc.) have been added/changes in the application.properties file. These changes need to be reflected in the application.properties.aws file as well such that cloud deployments reflect the same behavior.

Note:

# use only for development purpose, left it to true otherwise
openSearch.sslCertificateCNVerification=true

will not be added since it appears the default is desired and we do not want to introduce unintended behavior by adding this parameter (a bit twitchy about this parameter since it involves certs).

@jimmie
Copy link
Contributor Author

jimmie commented Dec 23, 2022

Will also move some config parameters around in application.properties.aws to agree w/ their locations in application.properties, making it easier to compare.

@jimmie
Copy link
Contributor Author

jimmie commented Dec 23, 2022

Note that this file (along with the registry-api jar file) is read in at the time the docker image is built so a new build of the registry-api artifacts is not necessary to support these changes.

@jordanpadams
Copy link
Member

closed per #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants