7703- Fixed spacing issues on product pages #7840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinang
previously requested changes
Nov 13, 2021
There was a problem hiding this comment.
- When there are multiple category tags on smaller viewports the spacing is off. Try left aligning and adding space above when it wraps on the next line:
- minimum security standards has a bit of space before it:
-
spacing between
What can be used to sign up?&What data does the company collect?sections look good and I think we don't need the faint dividers seen in the mockups actually so this works -
is the mobile tab alignment not fixable or should we file it as something separate?
|
This PR introduces visual differences. Click here to inspect the diffs. |
|
This PR introduces visual differences. Click here to inspect the diffs. |
sabrinang
approved these changes
Nov 15, 2021
|
I filed it separately here: #7862 |
fessehaye
force-pushed
the
7703-spacing
branch
from
2684e4e to
d2dca20
Compare
Pomax
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7703
Only changed that could not be included is
Tab alignment (starts a bit too far in on mobile)due to issues with sticky and scrolling css assigned to the header