Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI QA] Product Page — alignment, formatting & dividers #7703

Closed
4 of 5 tasks
sabrinang opened this issue Oct 26, 2021 · 3 comments · Fixed by #7840
Closed
4 of 5 tasks

[PNI QA] Product Page — alignment, formatting & dividers #7703

sabrinang opened this issue Oct 26, 2021 · 3 comments · Fixed by #7840
Assignees
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend qa
Milestone

Comments

@sabrinang
Copy link

sabrinang commented Oct 26, 2021

Desktop

  • add more spacing above the category label

image

Mobile

There are a few discrepancies on mobile:

  • Ding alignment

image

  • Tab alignment (starts a bit too far in on mobile)

image

  • spacing & dividers missing from Can it snoop on me?, What can be used to sign up? & What data does the company collect? sections (should be similar to formatting to what is currently live)

image

  • text & icon formatting for Does this product meet our Minimum Security Standards? section

image

@kristinashu
Copy link

@danielfmiranda just putting this on your radar. It doesn't have to be done this sprint but if you're looking for something PNI related this could be a good one!

@jamilasnell
Copy link

Seeing some similar issues related to alignment. This is only happening when I have my browser window fill half of my giant external screen (this isn't happening when my browser is fully expanded to full the external screen).

It is affecting the info icon in "Does this product meet our Minimum Security Standards" section under the security tab.

Screen Shot 2021-11-09 at 4 23 27 PM

Additionally, it is cutting off the Privacy Policy section as well.

Screen Shot 2021-11-09 at 4 23 23 PM

Here is what the full screenshot looks like:
Screen Shot 2021-11-09 at 4 23 19 PM

@kristinashu
Copy link

Thank you Simon for grabbing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend qa
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants