feat: Add Fares v2 page #89
Conversation
|
@isabelle-dr I'm going to seek community feedback on this, but first could you please
then I'll see if folks in the #gtfs-fares Slack channel have any thoughts. I'd suggest running the branch locally according to the README for the easiest review. |
There was a problem hiding this comment.
Nice work, I really like the shoutout to first adopters and the history 🎉
A few thoughts as I was reading this page:
- We could replace the existing link in the first paragraph of https://gtfs.org/schedule/examples/fares-v2/ to go to this new page
- The proposal authors: having the names in the docs instead of hardcoded in this page might be easier to maintain (because maintained by the proposal owners and not us). These authors (or "owners") might change over time and the original authors might not want to have their names here. To be confirmed with them.
- The table listing all the proposals: I expect many changes happening to the prioritization, and many new proposals to be drafted. I am wondering if a ProductBoard portal with a prioritized backlog / In Progress / Adopted might be a better strategy if we could embed it
- It would be a good place to provide a list of datasets that contain fares v2?
docs/extensions/fares-v2.md
Outdated
|
|
||
| ## In Progress Fares v2 Work | ||
|
|
||
| The GTFS community is currently working on finalizing the <a href="https://share.mobilitydata.org/fare-containers-to-fare-payment-types-proposal" target="_blank">fare_payment_options.txt (formerly fare_containers.txt)</a> proposal. |
There was a problem hiding this comment.
I think this info is a little duplicative of the table below. From a maintainability standpoint, having only one place to update what we are currently working on might be easier?
There was a problem hiding this comment.
Hoping the "what we are currently working on" will get updated more often in 2023 🙈
There was a problem hiding this comment.
The main value of this section to me is having a few sentences that someone can skim for a general update of
- what feature is being prepared for a vote
- which proposal they can look at to get up to speed
(and not having to scrounge through GitHub to find that update in a specific PR or issue).
It serves a different purpose than a list of proposals people have to read through on ProductBoard, since that's more for people who really want to get into the details. I imagine us updating this section every month or two. @isabelle-dr does that make sense to you or is there an alternative approach you'd prefer?
There was a problem hiding this comment.
Okay I understand better. Sounds good then.
Can you change the name to "fare container updated proposal"?
The name is back on the table 🙈
|
@isabelle-dr Updated - please review again and let me know what you think about my responses above. re: sharing a list of fares datasets here, I actually think the Files and Fields doc is a more natural place that's more intuitive for us to keep up to date. I can add this to my to do list when we start trying to discover more open fares-v2 feeds. |
docs/extensions/fares-v2.md
Outdated
| | Discussion | [GTFS-References](http://bit.ly/gtfs-references) | Elizabeth Sall, Cal-ITP | fare_transfer_rules, transfers, stop_times, pathways, stops | Same as the Cross Dataset Namespaces proposal. We need some way to represent relationships between different GTFS feeds. | Use references to identify when an entity (like stop, pathway, transfer, fare_transfer_rule) are shared across datasets. | | ||
| | Discussion | [fare_leg_join_rules.txt Proposal + Thoughts on “as_route”](https://bit.ly/gtfs-fares-v2-fare-leg-join-rules-proposal) | Brian Ferris, Google | fare_leg_rules | The as_route field proposed in the full Fares V2 proposal does not sufficiently support complex multi-leg fare behaviors. | Add fare_leg_join_rules.txt as a more general mechanism for indicating when multiple consecutive legs should be considered as one for the purposes of fare calculation. | | ||
| | Discussion | [Should fare transfers require that the same fare product is used on both legs?](https://docs.google.com/document/d/1zF5i03BFQi1kVBfN17aR7N1KRrpsHs3B9YjCzE8apJE/edit) | Nicholas Paun, Transit | fare_leg_rules, fare_products | It is currently ambiguous in the spec if the same fare_product must be used on both legs of a fare_transfer_rule in order for the transfer to be accepted. | Add 1 field to clearly define if the transfer requires the same fare_product or not. | | ||
| <iframe src="https://portal.productboard.com/rhk8dbtic1iqakfznucry448" frameborder="0" width="100%", style="min-height:600px;"></iframe> |
There was a problem hiding this comment.
This is great!
Just to make sure I understand the purpose here: this is quick access to all the proposals related to GTFS-fares v2, right?
If so, where is the best place to see the prioritized backlog? The next item we will be working on is the Variable pricing feature.
It's almost like we need a "triage" column to put all the proposals we receive, and then we put them in the backlog based on when we want to work on it.
There was a problem hiding this comment.
@isabelle-dr Right now that information is in our roadmap on the website. We could merge all this info into the main portal and just add a "spec proposal triage" column so everything is in 1 place.
|
@isabelle-dr Ready for review again + hopefully approval! One major change to note: I did end up making a fares-only portal that has all the same cards as the transit team one. I remembered how annoying it would be to see non-fares items. 🙈 |
|
Good call! LGTM, thanks for working on this @emmambd 🥳 |
* fares v2 extension page * add link to fares v2 on extensions page * fix first buttons margin * change official language to adopted * fares v2 page changes * updating roadmap link * update fare containers section * Fares page translations * fares v2 translations
* add glossaries to CLI config * GTFS Schedule example feed translations * exclude translations from search * fares v1 examples * fares v2 example translations * rename translation files fares v2 * frequencies example translations * pathways example translations * translations.txt examples translations * routes stops trips examples translations * continuous stop examples translations * feed info example translations * attribution example translations * examples index translations * remove edit link from translated pages * example index translations * changes index translations * GTFS schedule processes translations * [create-pull-request] automated change (#67) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * [create-pull-request] automated change (#68) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * [create-pull-request] automated change (#70) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * feat: Add clearer contribution info (#69) * update contributing information to clarity how translations work * applying feedback * about translations * [create-pull-request] automated change (#71) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * update home pages traditional chinese * validate page translations * [create-pull-request] automated change (#81) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * fix: update docs on translation contributions (#85) We want to welcome translation contributions, while being clear that any contributions may be subject to being overwritten in the future when there are documentation changes. * GTFS Schedule new extensions (#86) * feat: extension updates (#87) * GTFS Schedule new extensions * escape ASCII bars * [create-pull-request] automated change (#90) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * [create-pull-request] automated change (#92) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * location_type should be 1 (#93) * feat: Add Fares v2 page (#89) * fares v2 extension page * add link to fares v2 on extensions page * fix first buttons margin * change official language to adopted * fares v2 page changes * updating roadmap link * update fare containers section * Fares page translations * fares v2 translations * [create-pull-request] automated change (#94) Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> * zh-TW chinese homepage button fix * changes page fixes * example feed translation fixes * attributions example translation fixes * continuous stops example fixes * fares v1 example fixes * fares v2 example fixes * fares-v2 fixes * feed_info fixes * frequencies fixes * examples index fixes * pathways examples fixes * continuous stops add translations * frequencies fixes * example fixes * process translation fixes * validate translations * translate examples navigation * link fixes * qa changes * text-to-speech translations * fares translation fixes * changes translations * attributions * validate page * pathways * feed info * frequencies * translations page * feat: Add clearer contribution info (#69) * update contributing information to clarity how translations work * applying feedback * about translations --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: maximearmstrong <maximearmstrong@users.noreply.github.com> Co-authored-by: Brian Donahue <brian.donahue@vitreosolutions.com>
This page aims to give the community 1 easy place to find commonly referenced documents in community discussions on improving Fares. It includes
To do: add translations of the page once we receive feedback on the content.