Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schedule subnav page translations #66

Merged
merged 65 commits into from
Feb 14, 2023
Merged

fix: schedule subnav page translations #66

merged 65 commits into from
Feb 14, 2023

Conversation

emmambd
Copy link
Contributor

@emmambd emmambd commented Nov 29, 2022

This PR includes translations for submenu pages under Examples in https://gtfs.org/schedule/examples/translations/, including:

  • Example GTFS Feed
  • Fares v1
  • Fares v2
  • Frequencies
  • Pathways
  • Translations
  • Routes, stops, trips
  • Continuous stops
  • Text to speech
  • Attributions
  • Feed info

As well as the Changes and Validate pages.

It should be noted there seems to be recurring issues with Simpleen in deleting links (maybe an issue with markdown?) and not honouring glossary do not translate items, particularly for languages without the Latin alphabet. These have been resolved manually.

@emmambd emmambd requested a review from isabelle-dr November 29, 2022 21:57
@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ emmambd
✅ briandonahue
❌ github-actions[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@emmambd emmambd removed the request for review from isabelle-dr January 17, 2023 15:34
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josee-sabourin and @emmambd this is truly incredible 😍
This PR alone brings so much (so much!) value out there.
Are we going to announce this somewhere? LinkedIn? blogpost?

@emmambd
Copy link
Contributor Author

emmambd commented Feb 14, 2023

A big shoutout to @josee-sabourin for pitching in on this!

Since we already announced that we had translations on the website available, I don't think there's any new value for the community in sharing it. (I also still have to do the realtime example PR 😅)

I will do some brainstorming with Tu-Tho about how we could identify community members who would want to do translation reviews once every 3-6 months, once realtime is wrapped up as well.

* update contributing information to clarity how translations work

* applying feedback

* about translations
@emmambd emmambd merged commit 0212aed into main Feb 14, 2023
@emmambd emmambd deleted the schedule_examples branch February 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants