-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamped bump up jsoo and alcotest and dune #13777
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run ``` opam install alcotest.1.7.0 dune.3.9.1 js_of_ocaml.5.4.0 opam switch export opam.export ```
Inspired from #12978
dannywillems
force-pushed
the
dannywillems/revamped-bump-up-jsoo
branch
from
July 28, 2023 14:11
1bc9853
to
9e13ccc
Compare
!ci-build-me |
!ci-build-me |
This was referenced Jul 28, 2023
To get compatibility with js_of_ocaml.5, see https://github.com/mirage/digestif/releases/tag/v1.1.4
rbonichon
reviewed
Jul 31, 2023
!ci-build-me |
Co-authored-by: Richard Bonichon <richard.bonichon@o1labs.org>
!ci-bulid-me |
!ci-build-me |
7 tasks
digestif.ocaml must be used as digestif will otherwise use the C version, and jsoo stubs are not implemented
dannywillems
force-pushed
the
dannywillems/revamped-bump-up-jsoo
branch
from
July 31, 2023 18:17
c6d7277
to
3ffe6b3
Compare
!ci-build-me |
7 tasks
!ci-build-me |
!ci-build-me |
!ci-build-me |
This was referenced Aug 17, 2023
Closing as stale. This PR is referenced in #14829, so that it can be used as a starting point if / when work resumes on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: in draft because of this comment in snarkyjs. On hold atm.
Bumping up js_of_ocaml to 5.4.0, dune to 3.9.2 and alcotest to 1.7.0. Cherry-pick a commit from #13790 for consistency.
Since alcotest.1.5.0, alcotest-js is available.
A better integration of node has been made in dune >= 3.8.0 (I don't remember exactly the version).
And upgrading js_of_ocaml to revive #12978
It will be useful for crypto team to write tests running in JS and in native, see #13537.
If a library has alcotest tests, we can activate "for free" the jsoo tests by adding
(modes native js)
in thetests
definition. For instance, it is activated for base58_check in this commit. It will run automatically a new executable. It is executed in a node environment (dune uses the `node' executable available in the path). If needed, for instance to load wasm first, the node binary can be overwritten with:where
node_wrapper
is an OCaml program.Related snarkyjs and snarkyjs-bindings PR: o1-labs/o1js#1056 and o1-labs/o1js-bindings#102.
Current state:
pickles/ro.ml
src/lib/base58_check
: js alcotest tests do not work. Fixed by usingdigestif.ocaml
Checklist: