Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade js_of_ocaml #12978

Closed
wants to merge 4 commits into from
Closed

Upgrade js_of_ocaml #12978

wants to merge 4 commits into from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Apr 5, 2023

This PR bumps the js_of_ocaml version to the latest.

Checklist:

  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner April 5, 2023 14:59
@mrmr1993
Copy link
Member Author

mrmr1993 commented Apr 5, 2023

!ci-build-me

mitschabaude
mitschabaude approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet 🙌🏻

@mrmr1993 mrmr1993 requested a review from a team as a code owner April 5, 2023 15:47
@mrmr1993
Copy link
Member Author

mrmr1993 commented Apr 5, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Apr 5, 2023

!ci-build-me

1 similar comment
@mrmr1993
Copy link
Member Author

mrmr1993 commented Apr 5, 2023

!ci-build-me

dannywillems added a commit that referenced this pull request Jul 28, 2023
@dannywillems
Fix build error related to upgrade
1bc9853 
Inspired from #12978
dannywillems added a commit that referenced this pull request Jul 28, 2023
@dannywillems
Fix build error related to upgrade
9e13ccc 
Inspired from #12978
@dannywillems dannywillems mentioned this pull request Jul 28, 2023
Closed
16 tasks
@mrmr1993
Copy link
Member Author

Needs updating and fixing; converting to draft

@mrmr1993 mrmr1993 marked this pull request as draft September 13, 2023 19:25
@mrmr1993 mrmr1993 mentioned this pull request Jan 11, 2024
Open
@mrmr1993
Copy link
Member Author

Closing, tracked in issue #14829

@mrmr1993 mrmr1993 closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitschabaude mitschabaude mitschabaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @mitschabaude