-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main > Live #599
Merge main > Live #599
Conversation
* Update dynamic-profiles.md Create section for dynamic profile for `Developer Powershell for VS 2019` * Update dynamic-profiles.md Update name and remove `startingDirectory` * Update dynamic-profiles.md Explain a little better
* Update new-tab-same-directory.md * Update new-tab-same-directory.md
..these are now officially dynamic profiles.. so no longer need to be added as 3rd party as of Terminal v. 1.12. :)
"it's" should be "its" because it wouldn't make sense otherwise.
Add information on GUID generation based on microsoft/terminal#10374 and improve wording to make the importance of a profile GUID clearer.
Resolves #339
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com>
You left click to block select
Resolves #405
Adds missing code block closing backticks on line 101 which was causing the following sections to render incorrectly.
Mis-placed semicolon.
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
This will help print the current working directory correctly if it has a space in its name. It was previously stated on line 109 in the WSL example.
* 1.17 - Add documentation for `--pos` and `--size` cmdline args * Add minor wording tweak Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Learn Build status updates of commit 347712d: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
FWIW same warning about the --pos and --size pull request that only applies to 1.17! |
Learn Build status updates of commit c186d23: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
For the -pos and --size addition, we noted that it is only for preview and linked to the Terminal Preview version. |
The preview version with those arguments probably won't be released for another six weeks 😄 |
Oh! Thanks @DHowett! I misunderstood - I'll pull them back out and file a new PR for merging once it's released! 😜 |
Thanks @mattwojo! |
No description provided.