Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main > Live #599

Merged
merged 89 commits into from
Oct 6, 2022
Merged

Merge main > Live #599

merged 89 commits into from
Oct 6, 2022

Conversation

mattwojo
Copy link
Collaborator

@mattwojo mattwojo commented Oct 6, 2022

No description provided.

shgogna and others added 30 commits December 13, 2021 09:40
* Update dynamic-profiles.md

Create section for dynamic profile for `Developer Powershell for VS 2019`

* Update dynamic-profiles.md

Update name and remove `startingDirectory`

* Update dynamic-profiles.md

Explain a little better
* Update new-tab-same-directory.md

* Update new-tab-same-directory.md
..these are now officially dynamic profiles.. so no longer need to be added as 3rd party as of Terminal v. 1.12. :)
"it's" should be "its" because it wouldn't make sense otherwise.
Add information on GUID generation based on microsoft/terminal#10374
and improve wording to make the importance of a profile GUID clearer.
Resolves #483
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
alexbuckgit and others added 21 commits July 13, 2022 14:38
You left click to block select
Alternative way to set up is in issue #546. 
Adding this note to resolve #546.
Adds missing code block closing backticks on line 101 which was causing the following sections to render incorrectly.
Mis-placed semicolon.
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
This will help print the current working directory correctly if it has a space in its name. It was previously stated on line 109 in the WSL example.
* 1.17 - Add documentation for `--pos` and `--size` cmdline args

* Add minor wording tweak

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
@opbld33
Copy link

opbld33 commented Oct 6, 2022

Learn Build status updates of commit 347712d:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 347712d4089abc6e86fc0df5eb2b5d7ce20e3828 in branch main of repository https://github.com/MicrosoftDocs/terminal into branch live (commit 18f7e4e3d7374a866324741e6406791fac97cab5). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@DHowett
Copy link
Contributor

DHowett commented Oct 6, 2022

FWIW same warning about the --pos and --size pull request that only applies to 1.17!

@opbld31
Copy link

opbld31 commented Oct 6, 2022

Learn Build status updates of commit c186d23:

✅ Validation status: passed

File Status Preview URL Details
README.md ✅Succeeded
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/images/ssh-optonialfeatures.png ✅Succeeded View
TerminalDocs/tutorials/new-tab-same-directory.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mattwojo
Copy link
Collaborator Author

mattwojo commented Oct 6, 2022

For the -pos and --size addition, we noted that it is only for preview and linked to the Terminal Preview version.

@mattwojo mattwojo merged commit 69955b0 into live Oct 6, 2022
@DHowett
Copy link
Contributor

DHowett commented Oct 6, 2022

For the -pos and --size addition, we noted that it is only for preview and linked to the Terminal Preview version.

The preview version with those arguments probably won't be released for another six weeks 😄

@mattwojo
Copy link
Collaborator Author

mattwojo commented Oct 6, 2022

Oh! Thanks @DHowett! I misunderstood - I'll pull them back out and file a new PR for merging once it's released! 😜

@DHowett
Copy link
Contributor

DHowett commented Oct 7, 2022

Thanks @mattwojo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.