Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wt.exe default behavior #507

Closed
ghost opened this issue Feb 15, 2022 · 1 comment
Closed

wt.exe default behavior #507

ghost opened this issue Feb 15, 2022 · 1 comment
Assignees
@mattwojo

Comments

@ghost
Copy link

ghost commented Feb 15, 2022 •
edited by ghost
Loading

By default wt.exe opens new tab if no command is specified, according to documentation.

However, it does not seems to be the case, since the windowingBehavior property is set to useNew and new window is opened for every new instance.

I guess it may be helpful to add a line that says something like wt.exe behavior if affected by the windowingBehavior property.

At first I thought of creating this PR on my own, but then decided to write an issue, maybe the behavior is expected and I've missed something.
@mattwojo mattwojo self-assigned this Mar 7, 2022
mattwojo added a commit that referenced this issue Sep 1, 2022
@mattwojo
Address changed wt.exe behavior as identified in #507
3f7d5a0
@mattwojo
Copy link
Collaborator

mattwojo commented Sep 1, 2022

Thanks for pointing out this change in the default wt.exe behavior @ghost. I've updated the doc and added a note about the windowingBehavior property as you've suggested. Appreciate the contribution!

@mattwojo mattwojo closed this as completed Sep 1, 2022
mattwojo added a commit that referenced this issue Oct 6, 2022
@mattwojo @shgogna
@v-alje @JasonWHowell @Rosefield @sanamhub @Haltarys @Okeanos @cinnamon-msft @zadjii-msft @DimitriPapadopoulos @wsmelton @alexbuckgit @phil-blain @AdrienClairembault @TBBle @joshuacookdev @Aaron-Junker @JanDeDobbeleer @carlos-zamora @alexeygrigorev @twobiers @kodedylf @andreccosta @jharoonalishah @serd2011 @oseughu @ianjoneill
Merge main > Live (#599)
69955b0 
* Update dynamic-profiles.md (#438)

* Update dynamic-profiles.md

Create section for dynamic profile for `Developer Powershell for VS 2019`

* Update dynamic-profiles.md

Update name and remove `startingDirectory`

* Update dynamic-profiles.md

Explain a little better

* Update VS version info in 3rd party (#462)

* Update custom prompt tutorial w latest OMP steps (#467)

* Add themes link

* Bulk fix - Removing .localizationpriority (#469)

* Testing image (#474)

* Update new-tab-same-directory.md

* Update new-tab-same-directory.md

* Include note on how to save the directory of a pane (#473)

* Add decimal value note for pane size

Resolves #276

* Remove VS PowerShell and CMD for 3rd party 

..these are now officially dynamic profiles.. so no longer need to be added as 3rd party as of Terminal v. 1.12. :)

* Add faq for psreadline

* Fix formatting

* Remove space before code block

* Remove code block

* Fix link

* startingDirectory path for WSL no longer requires prefix

* Update custom-prompt-setup.md (#482)

* style: fix typo in new-tab-same-directory.md (#486)

"it's" should be "its" because it wouldn't make sense otherwise.

* Updated based on pull 9270 in Terminal repo

* GUID generation for dynamic fragments (#320) (#460)

Add information on GUID generation based on microsoft/terminal#10374
and improve wording to make the importance of a profile GUID clearer.

* FIx to close #484

* Typo

Resolves #483

* Add UTF8 note

Resolves #339

* Fix note formatting

* Merge release-1.13 into main (#492)

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>

* Minor intro rewrite (#487)

* typo fix

* Remove start from PowerShell commands

* winget link fix

* Link fix

* link fix

* link fix

* Add `bellsound` profile setting (#508)

* Fix typos found by codespell (#501)

* Change step to view themes on documentation site (#505)

* Set ms.topic: faq where YamlMime:FAQ (#506)

* Fix pkgmgr link

* troubleshooting: clarify WSL `startingDirectory` entry (#516)

* troubleshooting: Linux paths support in 'startingDirectory' was added in 1.11.2921.0

In 7cd48bc (startingDirectory path for WSL no longer requires prefix,
2022-01-07), the "Set your WSL distribution to start in the home
directory" section of the troubleshooting guide was updated to mention
that WSL paths can now be directly referenced, following
microsoft/terminal@a2a6050 (When launching wsl, promote the starting
directory to --cd (#9223), 2021-08-02).

The text mentions this feature was added in Windows Terminal
1.12.3472.0, but it actually dates back to v1.11.2421.0 (Preview) and
v1.11.2921.0 (Stable).

Update the text to mention the stable version, and link to this version
in the GitHub releases. Also slightly improve the wording (s/are now/can
now be/).

* troubleshooting: remove confusing 'Important' note about WSL 'startingDirectory'

In e7f739e (Docs updates for 1.11 release (#397), 2021-08-31), an
"Important" note was added to the "Set your WSL distribution to start in
the home directory" section of the troubleshooting page to mention that
'startingDirectory' now accepts Linux-style paths, following
microsoft/terminal@a2a6050 (When launching wsl, promote the starting
directory to --cd (#9223), 2021-08-02).

The note mentions that Linux-styled paths were accepted "on newer
versions of Windows", presumably meaning newer than 1903. Indeed, that
version was at the time mentioned in the text as the first Windows
vesion supporting the '//wsl$/' P9 prefix (it had been mentioned since
the WSL startingDirectory troubleshooting entry was created in da815cc
(Review troubleshooting page, 2020-05-04).

The text of the section was updated in 7cd48bc (startingDirectory path
for WSL no longer requires prefix, 2022-01-07) to add an example with a
Linux-style path, and to mention that this feature was added in Windows
Terminal itself (not in Windows), thus removing the mention of Windows
1903. However, the "Important" note was left, and it still confusingly
mentions that Linux-style paths are accepted on "newer" versions of
Windows, without mentioning newer than what.

Remove the note altogether.

* .gitattributes: mark '*.md' as Markdown files

Denote Markdown files as such with the 'diff' Git attribute [1]. This
allows various Git commands (diff [2, 3], grep [4, 5], log [6], blame
[7]) to show in which part of the "code" the changes are located in the
hunk header, i.e. the previous commit would be shown as

    diff --git a/TerminalDocs/troubleshooting.md
    b/TerminalDocs/troubleshooting.md
    index 4a880fa..2c9d14d 100644
    --- a/TerminalDocs/troubleshooting.md
    +++ b/TerminalDocs/troubleshooting.md
    @@ -40,8 +40,6 @@ ## Set your WSL distribution to start in the home `~` directory when launched
     }
     ```

    -> [!IMPORTANT]
    -> On newer versions of Windows, `startingDirectory` can accept Linux-style paths.

     ## Setting the tab title

Notice how the hunk header indicates the changes are in the "Set your
WSL distribution to start in the home" section.

The history of that specific entry can now be interrogated using

    git log -L:"Set your WSL distribution":TerminalDocs/troubleshooting.md

[1] https://git-scm.com/docs/gitattributes#_defining_a_custom_hunk_header
[2] https://git-scm.com/docs/git-diff#_generating_patch_text_with_p
[3] https://git-scm.com/docs/git-diff#Documentation/git-diff.txt--W
[4] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--p
[5] https://git-scm.com/docs/git-grep#Documentation/git-grep.txt--W
[6] https://git-scm.com/docs/git-log#Documentation/git-log.txt--Lltfuncnamegtltfilegt
[7] https://git-scm.com/docs/git-blame#Documentation/git-blame.txt--Lltfuncnamegt

* Remove version specifics relating to WSL paths

* New tab same directory (zsh) (#513)

* Add acrylic issues to troubleshooting (#518)

* Add acrylic issues to troubleshooting doc

* Add autohide cursor setting

* Add windows settings differentiator

* command-palette: simplify example for iterable commands (#511)

* Move iterable commands gif lower down

* Quoted the env-var for `setx PROMPT` (#502)

* Updated --title documentation to specify behavior for panes (#500)

* push (#520)

* json-fragment-extensions: output GUIDs in "registry format" (#515)

* fix(powerline): adjust docs to reflect oh-my-posh changes (#534)

* Merge release-1.14 into main (#544)

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

* Fix link

* Add package id command for winget (#548)

* clarify (#551)

* Merge release-1.15 into main (#554)

* Document keyboard selection (#552)

* minor tweaks

* Document scroll marks

* Fix warning

* Remove old preview labels

Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>

* Add selection to TOC

* Instructions for MINGW (#525)

* Instructions for MINGW

- Added instructions for MINGW
- Added a link to this file, so it's easier to find it for people who'd like to contribue

* Update TerminalDocs/tutorials/new-tab-same-directory.md

Co-authored-by: Philippe Blain <levraiphilippeblain@gmail.com>

Co-authored-by: Philippe Blain <levraiphilippeblain@gmail.com>

* Add missing [Shift] in key binding (#557)

* Fix PowerShell commands

Based on #527

* Add Starship example (#530)

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>

* Add Fish shell

Resolves #523

* Move Mingw under WSL section

* Add focus mode tip

Resolves #528

* Change bashrc config to bash_profile

Recommended in #556 so that the `PROMPT_COMMAND` variable isn't repeatedly appended on the start of every bash process.

Resolves #556

* [BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute (#553)

* Update interaction.md (#562)

You left click to block select

* Address changed wt.exe behavior as identified in #507

* Add note on upgrading Oh My Posh

* Add note about restoring CWD

Alternative way to set up is in issue #546. 
Adding this note to resolve #546.

* Add specific command for OMP install and version check

* Add FAQ for terminal vs shell

Resolves #405

* [BULK UPDATE] DocuTune - Fix build validation issues: docs-link-absolute (#577)

* Add missing code block closing backticks (#571)

Adds missing code block closing backticks on line 101 which was causing the following sections to render incorrectly.

* Update custom-schemes.md (#576)

Mis-placed semicolon.

* Merge release-1.16 into main (#584)

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>

* Merge release-1.16 into main (#586)

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>

* Release-1.16 into main (#587)

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>

* [BULK UPDATE] DocuTune - Rebranding links (#592)

* Update with Windows SSH info, location, and image (#598)

* Adds missing `:::column-end::: :::row-end:::` (#566)

* Edit: Typo in Line 143 in `PROMPT_COMMAND` (#568)

* Add double quotes to $PWD on line 148 (#569)

This will help print the current working directory correctly if it has a space in its name. It was previously stated on line 109 in the WSL example.

* 1.17 - Add documentation for `--pos` and `--size` cmdline args (#591)

* 1.17 - Add documentation for `--pos` and `--size` cmdline args

* Add minor wording tweak

Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com>

Co-authored-by: Shubham Gogna <36936863+shgogna@users.noreply.github.com>
Co-authored-by: Alma Jenks <v-alje@microsoft.com>
Co-authored-by: Jason Howell <5067358+JasonWHowell@users.noreply.github.com>
Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com>
Co-authored-by: Sanam <31341013+sanamhub@users.noreply.github.com>
Co-authored-by: Haltarys <45515869+Haltarys@users.noreply.github.com>
Co-authored-by: Nikolas Grottendieck <git@nikolasgrottendieck.com>
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Mike Griese <migrie@microsoft.com>
Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Co-authored-by: Shawn Melton <11204251+wsmelton@users.noreply.github.com>
Co-authored-by: Alex Buck <abuck@microsoft.com>
Co-authored-by: Philippe Blain <levraiphilippeblain@gmail.com>
Co-authored-by: Adrien Clairembault <42734840+AdrienClairembault@users.noreply.github.com>
Co-authored-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
Co-authored-by: Joshua Cook <me@joshuacook.dev>
Co-authored-by: Aaron Junker <aaron.junker@outlook.com>
Co-authored-by: Jan De Dobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com>
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
Co-authored-by: Alexey Grigorev <alexeygrigorev@users.noreply.github.com>
Co-authored-by: Tobi <22715034+twobiers@users.noreply.github.com>
Co-authored-by: Hans Kilian <hkkilian@gmail.com>
Co-authored-by: André Costa <andreccosta@me.com>
Co-authored-by: Haroon Ali Shah <jharoonalishah@gmail.com>
Co-authored-by: Sergey <45919738+serd2011@users.noreply.github.com>
Co-authored-by: Osemudiamhen Ughu <76438025+oseughu@users.noreply.github.com>
Co-authored-by: Ian O'Neill <ianjoneill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattwojo mattwojo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattwojo